search

Emurgo / yoroi-frontend

Yoroi Wallet - Cardano ADA Wallet - Your gateway to the financial world (extension frontend)
https://yoroi-wallet.com/
MIT License
337 stars 100 forks source link

Upgrade React #392

Closed ebeloded closed 5 years ago

ebeloded commented 5 years ago

While working on #383, I tried using React.Fragment to conditionally elements without adding another element to the hierarchy. This resulted in build or runtime errors, depending on which syntax I tried to use. Flow didn't provide any assistance in pointing out the problem (TypeScript would be more helpful here).

It turned out that the version of React used in the project is 16.0.0 (from September 2017).

There was a lot of awesome features introduced since then. Just to name a few:

Modern React development doesn't happen without these features. I think we need to upgrade React and dependencies that rely on it and resolve whatever problems pop up.

Any reason not to do it?

SebastienGllmt commented 5 years ago

The reason we're behind is that the base code for Yoroi was multiple years behind and we spent some time in December upgrading packages (including the upgrade to React 16). We still have a bunch of stuff that is outdated since I didn't want to increase by multiple major versions are a time so definitely still work that needs to be done on this side.