search

Emurgo / yoroi-frontend

Yoroi Wallet - Cardano ADA Wallet - Your gateway to the financial world (extension frontend)
https://yoroi-wallet.com/
MIT License
337 stars 102 forks source link

improve user friendliness while [ Create a new wallet ] OR [ Restore wallet from backup ] #46

Closed shinsuny closed 5 years ago

shinsuny commented 6 years ago

While [ Create a new wallet ] OR [ Restore wallet from backup ] if user presses ESC key or clicks somewhere apart from dialog box anytime then, Dialog box is closed and user have to repeat whole process even if he has written RECOVERY PHRASE and about to complete the wallet creation.

One Solution: we should only close dialog box if user presses "X" button.

image 2

nicarq commented 6 years ago

@sarveshwar-singh agreed. For now it’s low priority in comparison with the other tasks.

SebastienGllmt commented 5 years ago

We already do this for a lot of Dialog boxes. The Dialog class actually has a property for this if I remember correctly so it should be really simple.

shinsuny commented 5 years ago

@sarveshwar-singh Yes, just have to set closeOnOverlayClick={false}. Thinking to fix that in: https://github.com/Emurgo/yoroi-frontend/pull/285

Leo-Emurgo commented 5 years ago

Still not fixed, also "MOUSE UP" will close the window. Not just clicking.

In my own testing I accidentally close the window multiple times almost every time I try to restore a wallet due to this bug.