Emurgo / yoroi

Yoroi - Your Cardano entry point for joining the ecosystem, whether as developer or user.
https://yoroi-wallet.com/
Apache License 2.0
159 stars 49 forks source link

refactor(wallet-mobile): display native kb for device pin #3653

Open rahulnr7 opened 2 months ago

rahulnr7 commented 2 months ago

display native kb for device pin

Ticket

YOMO-1893

[!NOTE] Please create the ticket if missing it.

rahulnr7 commented 2 months ago

@jorbuedo Thanks for checking it. I tried an experiment based on your comments for using the hidden text inputs. The native kb does show up but looks like it is not consistent. I will try further to improve it. Here is a recording from iOS how it works.

Uploading Simulator Screen Recording - iPhone11 - 2024-09-24 at 15.54.37.mp4…

rahulnr7 commented 2 months ago

Simulator Screenshot - iPhone11 - 2024-09-24 at 16 21 23

jorbuedo commented 2 months ago

I don't like that in Android you can close the keyboard and then not have how to open it again. Maybe force a focus on the input when clicking anywhere on that screen?

rahulnr7 commented 2 months ago

@jorbuedo Yeah that seems to be an issue that I might need time to research. As this is earmarked for 5.1, will try again after closing the pending bugs. Thanks.