EnAccess / micropowermanager

Open Source Management Tool for Decentralized Utilities.
https://micropowermanager.io/
MIT License
2 stars 5 forks source link

Ft/production dockerfile #275

Closed Delyc closed 2 months ago

Delyc commented 2 months ago

This PR moves the frontend production docker file from Website/UI directory to Docker directory

dmohns commented 2 months ago

Hey @Delyc you are pulling in commit's that are already merged. Can you please rebase your branch to current main ?

dmohns commented 2 months ago

Two more comments:

  1. You are not moving the file, but copying it. Could you make sure to move it, i.e. so we don't have the file twice.
  2. Also, it would be great if we can move the Dev file for UI. But would probably require to change the Docker Compose file
dmohns commented 2 months ago

Hey @Delyc

This PR got a bit messy. Github doesn't detect the Dockerfile was moved, which would be great for organisational purposes.

I'm closing this PR. Could you please re-create this PR with

?

For example: https://github.com/EnAccess/micropowermanager/pull/279/files