Join / Login component - Githubissues

ddfridley commented 2 months ago

<Login 
    user={}
    onDone=()=>{valid, value}
/>

[x] see undebate-ssp/app/components/signin-signup.js for code to start with.
[x] If user is set, call render null and onDone({valid: true, value: user}) from with useEffect
[x] implement both the login tab (shown) and the join tab.
[x] After the user logs in, or joins, do the above.
[x] There is a skip method, see civil-client/app/components/use-auth.js for how it works. The skip requires the user to agree to the terms of service, but doesn't require name or email, but gives them a user id so they can go forward.
[x] Create a story for this component
[x] Use civil-client/.storybook/middleware.js to emulate the sign in / sign up operation in storybook. See if you can import it from "civil-client/.storybook/middleware" rather than copying it.

-- update 2024Jul17 --- The designer has made a few updates to this component. Please see figma

The changes are:

[ ] Style of the check box and agree to terms of services line. Note, only the one like with the check box is required, and the words 'terms of service' and 'privacy' should be links to https://enciv.org/terms and https://enciv.org/privacy
[ ] Notice the color of the checked check box
[ ] How error messages are rendered.

officialblooms commented 1 month ago

Can I get assigned this task?

ddfridley commented 1 month ago

@officialblooms I talked with the designer. When the user hovers of the Join (unselected) tab, it should be underlined, that is consistent with the way buttons work as shown here: https://www.figma.com/design/EFnBPfEEejKi6CVJGAQWJh/Civic-Pursuit-Tool%3A-Wireframe-%2B-Design?node-id=3-164&t=SBjStVC6WcobChnh-4

EnCiv / civil-pursuit