search

EnCiv / undebate-ssp

Undebate Self Service Portal- Web portal where election administrators of democratically run organizations create undebates for their candidates and voters
Other
6 stars 9 forks source link

Undebates list#21 #169

Closed ice1080 closed 2 years ago

ice1080 commented 2 years ago

@ddfridley here's the PR for the undebates list per your request; obviously not finished yet.

ddfridley commented 2 years ago

I have pushed an update to get-election-status-methods to this repo.

When I go to http://localhost:6006/?path=/story/undebates-list--all-moderator-options and click on the red button to filter on urgent, only 1 of the items shows up, but 2 are marked with the red bar on the left. Is this working as expected?

Thanks!

ice1080 commented 2 years ago

Ya I just added the candidate status of "All X Candidates Missed Deadline" to the list of urgent and haven't updated the filter logic to work with that. I need to figure out how to filter down to urgent for the whole row, since the regular filter works by filtering per column (which doesn't work here because there are two columns involved) and the global filter works by filtering per text displayed (which would be a bit hacky here). I think I have an idea on how to filter, just need to implement.

In case it got missed in the issue itself, for the search functionality, just confirming that the search bar at the top will only display after clicking the search magnifying glass, and that it will shift to the center of the screen instead of staying where it currently is?

ice1080 commented 2 years ago

Hey @ddfridley I still have a few items left on this, and open questions on the issue (and PR discussion). How should I go about doing the rest of the work?

ddfridley commented 2 years ago

Oops! I should have asked. But this looks so great. Just keep pushing to the same branch, and make another PR when you are ready.

Also, I have one request. Please use .toLocaleDateString() in the date column to get the date into US format. Kamal, the designer is in India. I didn't think about it until I started working with it. I think US users will appreciate it.