search

EnCiv / undebate-ssp

Undebate Self Service Portal- Web portal where election administrators of democratically run organizations create undebates for their candidates and voters
Other
6 stars 9 forks source link

Candidate invitations details#164 #192

Closed ice1080 closed 1 year ago

ice1080 commented 1 year ago

@ddfridley this one should fix the last two tasks of #164 as mentioned. Because I'm unable to post recordings locally I was unable to fully test this, so it should probably be tested on your side locally before merging. Let me know if there are any changes needed. Thanks!

ddfridley commented 1 year ago

@ice1080 I made a change and pushed it. The invites that was being passed to InviteSentComponent is an object of object, not an array.

But now I have a new challenge, after the candidate has recorded, it still says "Last Sent 1 days ago" so I think it should say submitted. But at that point we are duplicating the status column on the Submissions page. (And on that page, the sent stats just says sent and doesn't say the days ago". Is there an easy way to improve the Submission Status column logic and then use it in both places?

ice1080 commented 1 year ago

I remember looking into that and it not being very straightforward. If I remember correctly, one of the pages renders the component without passing any data to the render, so it would require quite a bit of refactoring to line them up. In the issue (#164) I had mentioned this and you said if we're going to be combining the pages eventually then it's less of a big deal? https://github.com/EnCiv/undebate-ssp/issues/164#issuecomment-1242853579 https://github.com/EnCiv/undebate-ssp/issues/164#issuecomment-1244550184

ice1080 commented 1 year ago

Also, regarding the change you made, it seems like iotas.json is getting further and further out of date. I definitely recognize that I should have looked at the wiki instead of assuming that file was true, but I recommend making that file line up with the wiki's structure so that future contributors don't make similar mistakes

ice1080 commented 1 year ago

@ddfridley just tested with my cloudinary url and I see everything working as expected now, including Post recording. This PR is ready for merging now unless you know of anything else you'd like merged in this.