search

EnCiv / undebate

Not debates, but recorded online video Q&A with candidates so voters can quickly can get to know them, for every candidate, for every election, across the US.
Other
20 stars 14 forks source link

add time limit for candidates' questions #222

Closed thong-pham closed 4 years ago

ddfridley commented 4 years ago

@Jack-Pham This is great, but when I tried it with some data from the live system, I found something else. I added a new record to the bottom of iota.json and pushed it up to this branch. If you git fetch and git pull this branch you should get it. Then just restart your server and your database will get updated from iota.json. Then go to localhost:3011/candidate-conversation-candidate-recorder-questions-test The problem is that the last line of questions is a little unusual and it's doesn't show the seconds. Can you figure out how to get the seconds there. Probably on the first line. Thanks!

thong-pham commented 4 years ago

@ddfridley The last questions section looks kind of weird. It contains two questions but doesn't have any title like "Introduction". If I put the time next to the first question, users might misunderstand that this time only apply for this question and the second one doesn't have any time.

ddfridley commented 4 years ago

@Jack-Pham Lets talk about it in the meeting tonight with the UI people. Also, I pushed a new merge with master. But maybe I repeated what you did a few minutes ago. Not sure, but great if you are proactively merging with new masters and pushing them!

thong-pham commented 4 years ago

@ddfridley Can you check PR again ?

ddfridley commented 4 years ago

Reviewed the format with Will and Kayla and they approved. We're go.