search

EnCiv / undebate

Not debates, but recorded online video Q&A with candidates so voters can quickly can get to know them, for every candidate, for every election, across the US.
Other
20 stars 14 forks source link

Hangup Button #268

Open ddfridley opened 4 years ago

ddfridley commented 4 years ago

We need a hangup button that is consistent with the new design of the other buttons.

We will need an SVG file, that is similar in format to the other buttons -- see https://github.com/EnCiv/undebate/issues/177 and https://github.com/EnCiv/undebate/files/4935390/updated.buttons.zip for the other buttons

ddfridley commented 4 years ago

Kristen is working on this but I don't have her in github yet

kawill commented 4 years ago

A potential solution: Maybe name the button closer to what it does ‘Delete Recording’ and have a confirmation modal with an overlay to draw the candidate’s attention desktop - delete recording desktop - delete recording overlay delete-recording-buttons.zip Figma Link: https://www.figma.com/file/wCHdJXu75RphBsOTs6LSyf/CC-9-2-20?node-id=5%3A8

ddfridley commented 3 years ago

@Jack-Pham This is the Issue where I'd like you to help with making the popup look like what's above. The branch is https://github.com/EnCiv/undebate/tree/recorder-setup The file to work in is: https://github.com/EnCiv/undebate/blob/recorder-setup/app/components/hangup-button.jsx Please make a separate branch for this.

One comment about the above picture, I like the way the current popup is near the button that you click on, rather than in the middle of the screen.

I'm going to be slow to be behind on testing and merging this week because of family medical care issues. I'm trying to get recorder-setup into master, but I have to finish the testing, and I'm waiting the improved mic-meter/mic and camera selector component that Dana is working on. Thx.