search

EnMAP-Box / enmap-box

EnMAP-Box source code repository. See https://enmap-box.readthedocs.io for documentation
GNU General Public License v3.0
35 stars 16 forks source link

Bug in beta leaf angle distribution within IVVRM (EnMAP-box 3.12.1) #507

Closed ClementAtzberger closed 1 year ago

ClementAtzberger commented 1 year ago

Dear all - please take note that the BETA (uniform, planophile, ...,and all other) leaf angle distribution creates some results that lead to INFORM (but also 4SAIL) to become insensitive to variations in cd (crown diameter), LAI, sd (stem density), h (height) .... This is evident when running INFORM (or 4SAIL) with the alternative (ellipsoidal) leaf angle distribution, where everything works well. Thanks - Clement

janzandr commented 1 year ago

Hi @ClementAtzberger, I will forward the issue to the LMU group (m.wocher@iggf.geo.uni-muenchen.de and tobias.hank@lmu.de).

Maesiu commented 1 year ago

Hi @ClementAtzberger, thank you for your report. Unfortunately, I cannot reproduce the insensitivity you are mentioning. Both with fixed ellipsoidal leaf angle or beta distribution, the output behaves similar with changes in LAIu, SD, H, and CD. However, there seems to be saturation effects in calculated reflectance:

reflectance variations in SD (orange) and CD (green): ALIA fixed to 45° (ellipsiodal):

grafik

LIDF set to plagiophile (beta dist.):

grafik

It would be nice though if we could validate our implementation/coupling of INFORM and PROSAIL based on another realization, e.g. Matlab.

In the EnMAP-Box you'll find our translation of the original Matlab code here:

C:/Users/%USERNAME%/AppData/Roaming/QGIS/QGIS3/profiles/default/python/plugins/enmapboxplugin/enmapbox/apps/lmuapps/lmuvegetationapps/Resources/PROSAIL

where call_model.py handles the different instances of RTM combinations.

janzandr commented 1 year ago

@ClementAtzberger , @Maesiu , not sure what's the status of this issue: is this a bug in EnMAP-Box or is this Matlab related? Can we close it?

ClementAtzberger commented 1 year ago

Hi - i think we can close it because it seems to happen only on my computer ... other colleagues do not face the same problem Thanks a lot for your help/assistance Clement

On Mon, Jul 10, 2023 at 11:29 AM Andreas Janz @.***> wrote:

@ClementAtzberger https://github.com/ClementAtzberger , @Maesiu https://github.com/Maesiu , not sure what's the status of this issue: is this a bug in EnMAP-Box or is this Matlab related? Can we close it?

— Reply to this email directly, view it on GitHub https://github.com/EnMAP-Box/enmap-box/issues/507#issuecomment-1628582663, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIWPMVUN4XCZEQCWSQ5TB3DXPPDQFANCNFSM6AAAAAAZL6IU7Y . You are receiving this because you were mentioned.Message ID: @.***>