search

EnMasseProject / enmasse

EnMasse - Self-service messaging on Kubernetes and OpenShift
https://enmasseproject.github.io
Apache License 2.0
190 stars 87 forks source link

Docs: add missing title #2916

Open famarting opened 5 years ago

famarting commented 5 years ago

I noticed a missing title inside the 4.2.2 Standard address space section about Hierarchical topics and wildcards , it looks like it's just missing the font style. Maybe Hierarchical topics and wildcards it's a subsection of the Topic section from above, I don't really know what should be the style applied, but what is clear is that something is missing there because it looks a bit weird IMO. The same happens to Known issue with creating a subscriber on a hierarchical topic in that section

https://enmasse.io/documentation/master/openshift/#con-standard-address-space-messaging

jenmalloy commented 5 years ago

@famartinrh, Thanks for raising an issue about this. I suspect it might be a style sheet issue that affects level 4 headings. I'm not very familiar with this build process, but I'll see what I can find out.

jenmalloy commented 4 years ago

@lulf Can you take a look at this issue and we can discuss?

lulf commented 4 years ago

We don't apply any style sheet to the docs. We're using the defaults from asciidoctor. My thinking is that it is just a too deeply nested heading. Looking at the HTML, it is given a "" tag, which is not valid HTML5, which is why it doesn't get styled at all.

lulf commented 4 years ago

Original issue where a solution is discussed: https://github.com/asciidoctor/asciidoctor/issues/3358