search

EnableIrelandAT / Coimbra

Project Coimbra was developed by independent volunteers at Microsoft with the Service Owners of Enable Ireland Sandyford. Inspired by their love of music and how it is such a central part of the service, volunteers at Microsoft developed this inclusive music software and have generously allowed us to share it with the world.
MIT License
4 stars 5 forks source link

Add editorconfig #20

Closed andreasbalzer closed 4 years ago

andreasbalzer commented 4 years ago

Automatically created by MsBuild but stored in sources. Do we need this?

muiriswoulfe commented 4 years ago

I'm not sure we require it. .editorconfig files normally specify the formatting, so I'm not sure why this is being added. Maybe we should add a useful one, which would help when using VS Code etc. You can find out more about .editorconfig at https://editorconfig.org/. One that I generally favour using, which generally adheres to the standard StyleCop guidelines can be found at https://github.com/RehanSaeed/EditorConfig

muiriswoulfe commented 4 years ago

I had another look into this and it looks like this shouldn't be committed to Git: https://stackoverflow.com/questions/64241729/new-generated-generatedmsbuildeditorconfig-file-since-recent-upgrade

If this continues to get auto-generated, it looks like we can <GenerateMSBuildEditorConfigFile>false</GenerateMSBuildEditorConfigFile> to the .csproj file based on https://github.com/dotnet/roslyn/issues/48430

muiriswoulfe commented 4 years ago

I've closed this as I now have a new PR out with the correct fix instead.