search

EnableSecurity / wafw00f

WAFW00F allows one to identify and fingerprint Web Application Firewall (WAF) products protecting a website.
https://www.enablesecurity.com/
BSD 3-Clause "New" or "Revised" License
5.17k stars 924 forks source link

Enhancing Project Performance: Asynchronous Implementation and Multithreading Support #192

Closed Zaeem20 closed 9 months ago

Zaeem20 commented 10 months ago

Dear Dev,

Upon reviewing your code, I noticed that you are currently using the requests library, which can potentially cause blocking IO. I would like to suggest implementing the same logic using aiohttp. This could allow the entire project to operate in an asynchronous manner, significantly enhancing the performance of scanning. There are various packages available for this purpose, such as aiohttp and httpx.

Alternatively, you could consider adding support for multithreading. While this would still operate in a synchronous manner, it could serve as a viable alternative.

I would be interested to hear your thoughts on these suggestions. Please note that these are merely suggestions aimed at enhancing the core functionality of the project.

Thank you, Zaeem Durani

foozzi commented 10 months ago

I believe the developers of wafw00f would appreciate it if you were to create a pull request.

0xInfection commented 9 months ago

Thanks for the input, however we do not have plans on asyncio support for now. It would be great if you can create a PR with the intended changes and we can gladly merge that in once everything is in order.