[Feature Request] Image pull secrets

Enapter / charts

Enapter Helm Charts

MIT License

48 stars 49 forks source link

[Feature Request] Image pull secrets #52

Closed ConstBur closed 2 years ago

ConstBur commented 2 years ago

Hello, I built a custom KeyDB image that I would like to pull from my private GitHub registry, so I'd need to indicate an image pull secret (https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry). Adding it like this to the values yaml didn't work:

...
image: eqalpha/keydb:x86_64_v6.3.1
imagePullSecrets: 
  - regcred
imagePullPolicy: IfNotPresent
...

Would it be possible to add a prop to pass through imagePullSecrets?

xxated commented 2 years ago

Same issue here. Any updates?

Antiarchitect commented 2 years ago

Hi guys was off due to vacations. Please take a look at 0.40.1 and read 0.40.1 Upgrade notice of the keydb chart's README carefully due to (minor) backward incompatible changes. Please report if any issues.

ConstBur commented 2 years ago

Hey @Antiarchitect, just upgraded and it worked like a charm! Спасибо! :smiley:

Antiarchitect commented 2 years ago

@ConstBur With love! Пожалуйста!