search

Enapter / charts

Enapter Helm Charts
MIT License
48 stars 49 forks source link

change cm-utils to secret #6

Closed cortopy closed 4 years ago

cortopy commented 4 years ago

The server.sh script may contain sensitive information if a password is given. Having the password as plaintext in a config map would expose this data

This PR changes the configmap into a secret for better security

drpebcak commented 4 years ago

For this to be a secret, you would have to base64 encode the config.

cortopy commented 4 years ago

what do you mean? the secret uses stringData. From the docs

For certain scenarios, you may wish to use the stringData field instead. This field allows you to put a non-base64 encoded string directly into the Secret, and the string will be encoded for you when the Secret is created or updated.

drpebcak commented 4 years ago

Oops, my bad! I guess I didn't think about it hard enough.