search

Enchanted-Games / block-place-particles

A NeoForge and Fabric mod that adds particles to various interactions in the game, such as placing a block or tilling dirt.
Other
2 stars 0 forks source link

[Feature Request] Seperate bubbles from placing particles #9

Open SvveetMavis opened 1 day ago

SvveetMavis commented 1 day ago

I think the bubbles from placing something underwater should be a separate config option to just the generic block placing option because I want the placing bubbles but don't want the normal placing particles for all blocks

Enchanted-Games commented 12 hours ago

The bubbles should be either enabled or disabled for all blocks, regardless of any block specific particle options. Is this what you are describing or is there something else happening instead?

edit: this is definitely a bug, the code returns too early before the bubbles are able to spawn if there is no particle for a block here: https://github.com/Enchanted-Games/block-place-particles/blame/fc2440bfb1a2062154ffb75be4107d035aab449c/common/src/main/java/games/enchanted/blockplaceparticles/particle_spawning/SpawnParticles.java#L33