search

Enclavely / tailor

Build beautiful page layouts quickly and easily using your favourite WordPress theme.
https://www.tailorwp.com
GNU General Public License v3.0
1.05k stars 102 forks source link

Unable to close editing box on Wordpress 4.9 #159

Closed fatherb closed 7 years ago

fatherb commented 7 years ago

I realise this has been discontinued but maybe someone can help to figure out what is going wrong with Wordpress 4.9, which included customizer updates. It would appear whatever they did now interferes with the editing functions in Tailor.

Pushing 'Apply' or the X button in the editing box of Tailor greys out the box and makes any more editing impossible (screenshot below).

screenshot 2017-11-17 17 47 10

qoalu commented 7 years ago

what is discontinued?

richardtape commented 7 years ago

@qoalu

https://www.tailorwp.com/discontinued/

qoalu commented 7 years ago

yeah, just found this in the blog a moment ago. I am aghast as we are in the process of moving our whole website from VC to Tailor and I love the editor. The best out there. I hope some people from the community will step forward and help out. I would definitely be in as I was already contemplating about contributing.

Coming back to the topic, I have the same issue.

reefki commented 7 years ago

I think it's because some recent changes in color-picker.js https://github.com/WordPress/WordPress/commit/b43ddef0bccb41c00dbed9049a0cb54c5b725383#diff-9c3519f4870fac83dc0dbf18cb6bd4c4

Tailor is the best page builder ever and it's sad to hear it has been discontinued. I hope that @andrew-worsfold will do something to save his masterpiece.

SaveTailor

reefki commented 7 years ago

Tried to update color alpha script with the newest version https://github.com/kallookoo/wp-color-picker-alpha but it looks like the alpha slider doesn't show up.

screen shot 2017-11-20 at 19 56 53

reefki commented 7 years ago

After some digging I got it to work:

screen shot 2017-11-20 at 20 15 43

If you want to try it out you can replace tailor/assets/js/dist/sidebar.js with https://gist.github.com/reefki/d4addff26bef3877b58dd572276dc80e and turn on script debugging by placing define('SCRIPT_DEBUG', true); into your wp-config.php.

I really want to create a pull request but I doubt someone from @Enclavely willing to merge it.

fatherb commented 7 years ago

Hi - I downloaded sidebar.js from your gist.github, placed it in tailor/assets/js/dist/ and ran npm install - then made a zip file of the tailor folder. Then deactivated and deleted Tailor from Wordpress and uploaded the new zip file. I'm still seeing the same problems with not being able to close the editing box.

I think there are errors in the new sidebar.js file - is that possible? The plugin editor says line 1 is a problem.

reefki commented 7 years ago

No need to run npm install just replace the tailor/assets/js/dist/sidebar.js, also no need to deactivate and re-upload the plugin you can directly replace the file using FTP client. Don't forget to enable SCRIPT_DEBUG as I stated above in order to make WordPress loads sidebar.js instead of sidebar.min.js.

fatherb commented 7 years ago

Thanks. Tested and confirmed working. Editing box issue has gone. Well done! I think you should submit an update request to have this included. Otherwise do we have to branch it and put it in the wordpress plugins repository as a new plugin? I don't really understand how github works...

reefki commented 7 years ago

@fatherb I still have a pull request pending that makes me doubt they will even consider merging my pulls.

I would rather wait for @andrew-worsfold decision, we all know he doesn't have enough spare time to focus on maintaining it, but I believe he doesn't pleased to see something that he created from the ground with so many efforts and times leave abandoned at least we hope he will do something to make it work on WP 4.9.

Otherwise, let's hope someone will jump in to take control of this repository.

arashohadi commented 7 years ago

Here's @reefki's fix minified (sidebar.min.js). Just tried it on one of my sites and it worked. This way you don't have to change SCRIPT_DEBUG.

https://gist.github.com/arashohadi/f0cfa6464ad12d0b8c6bc6d4ea526dd7

arashohadi commented 7 years ago

@reefki Is it possible to make your changes in assets/js/src folder? There is a colorpicker.js in that folder for instance. I could help with the compilation and minification after that. I would do it myself but I don't know what you have changed :)

reefki commented 7 years ago

@arashohadi I have another modified version on my local machine and yes I modified it from src folder then compile them. But still not final because when you click on any of color in palette list the value in text field becomes empty.

https://gist.github.com/reefki/78786d5552eae1b8c86a5cfa3449dc8a

arashohadi commented 7 years ago

@reefki Ok thanks, please keep the rest of us updated if you manage to solve it. Thanks!