search

Enclavely / tailor

Build beautiful page layouts quickly and easily using your favourite WordPress theme.
https://www.tailorwp.com
GNU General Public License v3.0
1.05k stars 102 forks source link

Adding one more !default declaration in _variables.scss #92

Closed kipraske closed 7 years ago

kipraske commented 7 years ago

Our team is using Tailor for some of our WordPress sites and we are overriding tailor's styles by compiling our own frontend css in our own custom plugin. You have made this very easy by adding !default to all of the variable declarations, so all we have to do is re-declare the variables we want to change in our own custom sass file when we compile it and we are done.

Well somehow the $background-color didn't get a !default tag which happens to be a variable that we want to change for an upcoming site.

This is such a small change I could have just made an issue and let you deal with it, but this way you can easily see exactly the line of code I am referring to.

I also added a semicolon to the end of the file, but that is not really important. You can do that if you want too.

andrew-worsfold commented 7 years ago

Thanks for this, @kipraske. Small change, yes, but I appreciate you taking the effort!