Closed ro-savage closed 6 years ago
Ready for review.
This is a lot of code, and way too much for one PR. But it ended up being a merge of a bunch of branches.
Good luck. Main thing to check is functionality. Can you type an address, get an estimate, send it, and get back the details.
Probably worth leaving them for now, gives quick access to our orders if we even want to pick one to test with.
On 7/03/2018 14:52, "Ro Savage" notifications@github.com wrote:
@ro-savage commented on this pull request.
In server/src/api.js https://github.com/NAVCoin/NavMorph/pull/198#discussion_r172720152:
@@ -0,0 +1,30 @@ +"use strict"; + +const express = require('express') + +const router = express.Router([]) +const TransactionCtrl = require('./lib/db/transaction.ctrl') +const ChangellyCtrl = require('./lib/changelly/changelly.ctrl') +const OrderCtrl = require('./lib/order/order.ctrl') +const EtaCtrl = require('./lib/order/eta.ctrl') +const OrderStatusCtrl = require('./lib/order/status.ctrl') + +// TODO: Matt -- What are theses? Do they actually doing anything? +router.get('/db/transaction/:id', TransactionCtrl.getTransaction) +router.get('/db/transaction', TransactionCtrl.getTransaction) +
So we should delete them? OR do you want to keep them for testing?
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/NAVCoin/NavMorph/pull/198#discussion_r172720152, or mute the thread https://github.com/notifications/unsubscribe-auth/AMFcMhMjpttjkgIr6MqSBUI652yPXxLrks5tbz1EgaJpZM4SeAd9 .
Code looks good, will test tonight when I'm home or tomorrow morning first thing.
This PR updates NavMorph to handle Changelly's new API and return our new standardised API.
{data: {}}
responseTesting
npm install
to get new modulesnpm start
in frontendnpm start
in serverFunctional Testing
Unit tests
Code review