[Feature]: Add compact representations for input/output.

EncryptSL / LiteEco

Minecraft Economy Plugin works with vault.

19 stars 8 forks source link

Closed LcyDev closed 11 months ago

LcyDev commented 11 months ago

52 ✅
Implemented compact representations for input with validateAmount().
Implemented compact representations for output/display in liteEco.api.formatting()
Refactored repeated code for amount validation with validateAmount()
Implemented temporal translation for format_amount_error
Added config plugin.economy.compact_display to toggle compact representations for output.

LcyDev commented 11 months ago

Foolproofing: imagen

Usage imagen

There may be a problem when it rounds compact numbers for example "10.928M" to "10.93M"

However this only happens to the output, the real value is still correct.

LcyDev commented 11 months ago

@EncryptSL What do you think of these changes?

Sorry i made excessive commits. Maybe i'll redo this in a new branch and do a new pull request

EncryptSL commented 11 months ago

Changes looks good.

LcyDev commented 11 months ago

Thanks, i'm working in other plugins but i'm still contributing to this plugin

I will upload the new pull request of this feature soon.

EncryptSL commented 11 months ago

Yep no problem