Endalion / trackwork

A Minecraft VS2 Create Automotive addon
MIT License
20 stars 10 forks source link

Trackwork on server is bugged and crashes sometimes after a short time. 1.20.1 v1.0.1beta on Forge #12

Open Billnotic opened 1 week ago

Billnotic commented 1 week ago

HERE IS AN EXAMPLE PORTION OF THE SERVER LOG: [07Sep2024 05:21:40.369] [Physics thread/ERROR] [org.valkyrienskies.core.impl.shadow.Ap/]: Error in physics pipeline background task java.lang.NullPointerException: Cannot read field "trackPos" because "data" is null at edn.stratodonut.trackwork.tracks.data.PhysEntityTrackData.from(PhysEntityTrackData.java:60) ~[trackwork-1.20.1-1.0.1-beta.jar%23702!/:1.20.1-1.0.1-beta] at edn.stratodonut.trackwork.tracks.forces.PhysEntityTrackController.applyForcesAndLookupPhysShips(PhysEntityTrackController.java:64) ~[trackwork-1.20.1-1.0.1-beta.jar%23702!/:1.20.1-1.0.1-beta] at org.valkyrienskies.core.impl.shadow.Aq.a(Unknown Source) ~[valkyrienskies-120-2.3.0-beta.5.jar%23707!/:?] at org.valkyrienskies.core.impl.shadow.At.a(Unknown Source) ~[valkyrienskies-120-2.3.0-beta.5.jar%23707!/:?] at org.valkyrienskies.core.impl.shadow.Ap.run(Unknown Source) ~[valkyrienskies-120-2.3.0-beta.5.jar%23707!/:?] at org.valkyrienskies.core.impl.shadow.At$1.a(Unknown Source) ~[valkyrienskies-120-2.3.0-beta.5.jar%23707!/:?] at org.valkyrienskies.core.impl.shadow.At$1.invoke(Unknown Source) ~[valkyrienskies-120-2.3.0-beta.5.jar%23707!/:?] at kotlin.concurrent.ThreadsKt$thread$thread$1.run(Thread.kt:30) ~[kotlinforforge-4.10.0-all.jar%23604!/:?] [07Sep2024 05:21:40.370] [Physics thread/ERROR] [org.valkyrienskies.core.impl.shadow.Ap/]: !!!!!!! VS PHYSICS THREAD CRASHED !!!!!!! (message sent 8 more times in the log lol) [07Sep2024 05:21:40.371] [Physics thread/WARN] [org.valkyrienskies.core.impl.shadow.Ap/]: Physics pipeline ending

HERE IS A CRASH REPORT: https://api.mclo.gs/1/raw/HYtkfoV

blockninja124 commented 1 week ago

This crash specifically happens when Billnotic pastes in a specific tank schematic. The schematic itself is from the discord support post here. (I can’t send the file itself from my phone since it refuses to let me because it’s an unknown extension I guess)

Billnotic commented 6 days ago

For ease of testing, here is a direct download link to the schematic: https://cdn.discordapp.com/attachments/1281841736158675005/1283179506072289320/piston_mk1.nbt?ex=66e2b64a&is=66e164ca&hm=44bdc189d6e32661fb29965db966221fd7a47a2f0c4338f3d1a07e25a7adc22e& (When infusing physics the kelp belts glitch out a bit and have to be replaced).

Additionally, blockninja123's comment makes it seem like its specifically that tank schematic, which isn't verified. While I haven't tested on the server (due to there being players and I want to avoid crashing with people online), the only VS physics object made with Trackwork components WAS that tank so there is no way to know if its a larger issue affecting all creations or not.

blockninja124 commented 6 days ago

True, I just assumed it was only your schematic considering no-one else has reported seeing this issue widespread. Its possible it is in fact a large problem with trackwork that your tank schematic simply makes obvious.