Endangered-Language-Alliance / ela-website

Endangered Language Alliance website
1 stars 0 forks source link

Map init #10

Closed abettermap closed 3 years ago

abettermap commented 3 years ago

a few things coming along nicely:

abettermap commented 3 years ago

@rperlin-ela not ready to merge yet but decent progress today so feel free to poke around the deploy with minimal expectations. i heard mobile improvements are another side effect of Moderna ☝️

can start tackling one of these tomorrow, any requests?

  1. youtube thumbs
  2. projects map gonna hold off until we've got a good layout for langs map/s
  3. Home page
  4. better nav dropdowns
  5. burger on the grill
  6. lang instance
  7. ???

btw i broke the langs links to indiv lang instances, e.g. Bukhori. will fix tomorrow if i remember.

abettermap commented 3 years ago

Also anything to do with the blog could use some love.

rperlin-ela commented 3 years ago

Pretty nifty-looking stuff from a first glimpse, will keep poking around when I can. I'd vote 1 or 3 for most inspiring next step. (In terms of the homepage, I know you like going home, but maybe we won't neeed a Home in the nav when we have the logo to click on? I ask bc I don't see in the WP Menu structure)

abettermap commented 3 years ago

I'm fine with just the logo but I'm not sure everyone knows that this is a standard thing. Up to you, I could go either way.

I removed the home item from the menu so that I could hardcode it and use different text for the link name instead of the longer title used in the page. If that makes sense.

abettermap commented 3 years ago

I can take a stab at the YouTube stuff tomorrow. think you can conjure up another YouTube API key for me again? You've got to be a pro at this by now. ;)

We can't use the same one we use for the language map because it's a different domain, and while I could create one myself using the team account Dan gave me, I'd rather keep all the key stuff in your hands.

Let me know if you get stuck, I get stuck every time haha

abettermap commented 3 years ago

If it helps you can go look at your setup for the language map YouTube API key, it should be the exact same process, we'll just have a couple different domains this time.

abettermap commented 3 years ago

@rperlin-ela solid progress w/the thumbs sitch today: https://deploy-preview-10--ela-website-j-dev.netlify.app/languages/bukhori

should all be clickable to open modal.

is this roughly what you were going for or something griddy? lots of info to show and grid would eat up more space than the side scroll, so works for me. could do smaller thumbs too (obvi w/smaller triangle), although the black strips make it look too film-strippy:

image

strips come straight from youtube's thumbs though, and those thumbs are the smallest size. the one in the deploy is medium. would prefer to stick w/the standard youtube sizes and not fight the style or do math, so let me know if you're good w/medium.

abettermap commented 3 years ago

if you're around tomorrow before we chat... feed me some more content! i'm getting sick of looking at Bukhori 24/7 haha

rperlin-ela commented 3 years ago

This looks great! Totally on point.

abettermap commented 3 years ago

good progress on langs landing and instance pages today. much styling to do yet and will have questions on how to word a lot of the btns but it's coming along well.

btw i got the "dynamic summary for languages landing page" working. it's not exactly intuitive where to find it, but it's the Post Type Description on this page.

probably best to not go mucking around in there too carelessly, just go in and change that box if needed, then click Save Post Type .

i'm not really sure where else to put it at the moment. it's not a site-wide thing, it's not Home settings, just doesn't fit anywhere. it's literally the only page in the whole site besides /projects whose intro can't be controlled, not to mention it didn't come up until i mentioned it, so long story short i don't want to spend a bunch of time adding one more customization to the mix if it can be avoided.

abettermap commented 3 years ago

too many "WIP's" to type out but have a look around if you want: https://deploy-preview-10--ela-website-j-dev.netlify.app/languages

rperlin-ela commented 3 years ago

Sounds good, and that’s totally good about Post Type Description, makes sense to me.

One thing about Latest: when I click on a year and get to, let’s say, "2018 posts”, I think there should be a way other back button to get back to others. Not sure if that’s a breadcrumbs thing, or if clicking 2018 could just take the user to an anchor-like place in the whole list where 2018 posts start, but just mentioning

On May 17, 2021, at 7:47 PM, Jason Lampel @.***> wrote:

too many "WIP's" to type out but have a look around if you want: https://deploy-preview-10--ela-website-j-dev.netlify.app/languages https://deploy-preview-10--ela-website-j-dev.netlify.app/languages — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Endangered-Language-Alliance/ela-website/pull/10#issuecomment-842716526, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5DBNHGVAG7URHJTFDLTOGTHXANCNFSM445L4HTA.

abettermap commented 3 years ago

Hmm if I'm understanding correctly then breadcrumbs will cover this. The pages are already set up for /latest/:year/:slug though and that's how it is on the current site as well. Would have to change an awful lot of things to make it /latest/:slug

Not sure I'm following but breadcrumbs seem to be the answer?

rperlin-ela commented 3 years ago

Sure, not a big deal, let’s see how the breadcrumbs shake out.

On May 17, 2021, at 9:32 PM, Jason Lampel @.***> wrote:

Hmm if I'm understanding correctly then breadcrumbs will cover this. The pages are already set up for /latest/:year/:slug though and that's how it is on the current site as well. Would have to change an awful lot of things to make it /latest/:slug

Not sure I'm following but breadcrumbs seem to be the answer?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Endangered-Language-Alliance/ela-website/pull/10#issuecomment-842755151, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5HLWNBILPKHVHY3BT3TOG7R3ANCNFSM445L4HTA.

abettermap commented 3 years ago

Hopefully they'll shake out well because they're a semi-standard nav approach, and I don't know of any alternatives besides a dropdown menu or something similar.

I think I may be misunderstanding the issue/problem though so just going to move forward with breadcrumbs.

abettermap commented 3 years ago

Pushed up some improvements, have a look at deploy if you get a chance. Again too many WIPs to type but map for language instance, landing, and project instance are roughly in the layout I think is decent.

rperlin-ela commented 3 years ago

Thanks, only time for a quick look, but looking good!

On May 18, 2021, at 11:22 PM, Jason Lampel @.***> wrote:

Pushed up some improvements, have a look at deploy if you get a chance. Again too many WIPs to type but map for language instance, landing, and project instance are roughly in the layout I think is decent.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Endangered-Language-Alliance/ela-website/pull/10#issuecomment-843713553, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5D2KELEUEZNRHKXCFLTOMVGNANCNFSM445L4HTA.

abettermap commented 3 years ago

pushed up some goodies just now. main highlights:

  1. langs landing cards and markers. let me know if you like this approach. hopefully 'cause i do and it took a bit of work! will polish it up tomorrow but it should give you something to play with. note that i hard-coded the continents colors. hopefully we can avoid more wp config since they'll never change. i used the UN map and the most "medium" color from each region in it. if we need more or different let me know: image
  2. good call on those hero chips and the vertical sequence of All The Lang Instance Stuff in general. diggin it!
  3. see commit log for more updates

i accidentally set the nav items too small a font from wide phone up to 1921px, will fix.

abettermap commented 3 years ago

i used the same marker style on project instance as i did lang landing. not sure if the symbol labels (the periodic-table-2-char-deals) make as much sense out of context since continents are not as apparent nor are city names (although i guess that's the same for langs landing as well):

image

but a good ol' fashioned click solves the periodic-table-elem mystery:

image

for langs landing i haven't wired up the group-by-continent yet, but that's still the plan right? these would make more sense that way (e.g. an Asia section w/all but Garifuna):

image

for card subtitles i know it looks a bit off w/o the endo, so i'm not sure what to do w/that. i like the width and height of the cards so i'm axing my "side by side title and subtitle" idea in favor of sub below title.

maybe it will look less weird once they're grouped since maybe ALL the non-roman ones will have endos maybe? i'm not banking on that though so let me know if other ideas for sub-less cards.

rperlin-ela commented 3 years ago

Lots of great stuff, been digging around, also trying to slam some pages together even if they’re incomplete.

Yeah, definitely group-by-continent still feels right. Color-coding looks good

Cool idea but not sure about the little periodic table codes, at least in the little language cards. The places are pretty random and there’s going to be a lot of them, so I think it could get busy. I thought about country codes (they have two digit deals for that too), which people might have a chance of grasping more intuitively, but I’m still worried when there are like 100 of these things (on the lang landing page) and like 60 (on project landing). What’s your take?

Probably the vast majority will have an endo— no inspiration on this, but maybe it’ll look alright depending on what we do with the rest of that card

Small questions:

Is there an easy way to axe the footer nav on mobile? Dig the fatty footer on desktop but on mobile it feels like overkill. And I see that “Join our mailing list” is still going on to a second line, sorry just irking me for some reason. Kill Sanity Check if that’s affecting anything?

Seems like modal nav comes up short (or at least the solid black background does) on mobile landscape?

Probably missed a beat, but not sure how to add Projects in Menu > Appearance.

On May 20, 2021, at 10:13 PM, Jason Lampel @.***> wrote:

i used the same marker style on project instance as i did lang landing. not sure if the symbol labels (the periodic-table-2-char-deals) make as much sense out of context since continents are not as apparent nor are city names (although i guess that's the same for langs landing as well):

https://user-images.githubusercontent.com/4974087/119071390-561ba600-b9af-11eb-88e6-302e7b24f9a5.png but a good ol' fashioned click solves the periodic-table-elem mystery:

https://user-images.githubusercontent.com/4974087/119071490-87947180-b9af-11eb-962b-1c569b5ab495.png for langs landing i haven't wired up the group-by-continent yet, but that's still the plan right? these would make more sense that way (e.g. an Asia section w/all but Garifuna):

https://user-images.githubusercontent.com/4974087/119071582-b01c6b80-b9af-11eb-81e6-f94a0272b20b.png for card subtitles i know it looks a bit off w/o the endo, so i'm not sure what to do w/that. i like the width and height of the cards so i'm axing my "side by side title and subtitle" idea in favor of sub below title.

maybe it will look less weird once they're grouped since maybe ALL the non-roman ones will have endos maybe? i'm not banking on that though so let me know if other ideas for sub-less cards.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Endangered-Language-Alliance/ela-website/pull/10#issuecomment-845601440, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5CBVMQWHIFDK2KZ75DTOW6UNANCNFSM445L4HTA.

abettermap commented 3 years ago

The places are pretty random and there’s going to be a lot of them, so I think it could get busy. I thought about country codes (they have two digit deals for that too), which people might have a chance of grasping more intuitively, but I’m still worried when there are like 100 of these things (on the lang landing page) and like 60 (on project landing). What’s your take?

yeah i agree, it'll be like uhhhh which one is the red "Bu"?

so, how about numbers? like yelp does it:

image

so we'd:

  1. group by continent
  2. sort alphabetically within each continent section
  3. assign number based on position

if so then i'll need chubbier markers to fit double-digit nums.

Probably the vast majority will have an endo— no inspiration on this, but maybe it’ll look alright depending on what we do with the rest of that card

would it be the end of the world if the english name was used as the endo? i know it's redundant but it:

  1. avoids confusion about the empty space and immediately says "oh it's the same in english, got it"
  2. preserves the layout
  3. means wed don't have to look for other fluff to fill it in

Is there an easy way to axe the footer nav on mobile?

hmm i don't think that's a good idea to remove navigation but if you don't think it's useful i can. it's allllll the way at the bottom of the page though, not exactly in the way, and it serves the same purpose as it does on desktop.

And I see that “Join our mailing list” is still going on to a second line

Nitpick Friday, starring your host... Ross! :) yeah i'll set it to not wrap but just know that the remaining columns might not be centered. it's pretty subject to screen size.

Kill Sanity Check if that’s affecting anything?

i'll kill the paragraph and heading but would like to leave sitemap link in for internal usefulness. it won't be in prod.

Seems like modal nav comes up short (or at least the solid black background does) on mobile landscape?

gahhh why do people turn their phones sideways haha. ok good catch, far lower priority but i'll put it on my list.

Probably missed a beat, but not sure how to add Projects in Menu > Appearance.

image

look at all those beauties coming in!

rperlin-ela commented 3 years ago

so we'd:

  1. group by continent
  2. sort alphabetically within each continent section
  3. assign number based on position

if so then i'll need chubbier markers to fit double-digit nums.

Sounds promising, but how would this interact with clustering (if that uses a number)? Still got a lot of markers to number, and with a thin map I don't expect too many people to be hunting for 88 in Nepal. I'll try to add a bunch of locations today so there's more to work with.

would it be the end of the world if the english name was used as the endo? i know it's redundant but it:

Ok, let's give it a try (on these cards only I assume)

hmm i don't think that's a good idea to remove navigation but if you don't think it's useful i can. it's allllll the way at the bottom of the page though, not exactly in the way, and it serves the same purpose as it does on desktop.

look at all those beauties coming in!

Probably missing something simple but when I go to Appearance > Menu, I don't see any Projects or Languages (can't search for them either)

Screen Shot 2021-05-21 at 11 38 41 AM (2)

abettermap commented 3 years ago

Sounds promising, but how would this interact with clustering (if that uses a number)?

no idea. probably just a gray circle w/the count i guess? if that's confusing w/the other actual markers' numbers then could do letters instead? A,B,C,D... etc.

not sure really. clustering is a very complex requirement that somehow got tacked on, so i'd rather not sacrifice some of the many other remaining requirements if there's a better solution. i can look into handling it w/the same "hide if crowded" behavior we use on nyc map, but i'm semi-sure that's only for vector tiles, aka tilesets, not markers unfortunately.

I don't expect too many people to be hunting for 88 in Nepal

are there really going to be 88 Asian languages? my thought was that the numbering would start at 1 for each continent, not the whole set.

Ok, let's give it a try (on these cards only I assume)

not sure what you mean. as in just cards, not hero for lang instance? yes that's right.

Probably missing something simple but when I go to Appearance > Menu, I don't see any Projects or Languages (can't search for them either)

it's not a Page. you have to click Projects on left side:

image

abettermap commented 3 years ago

And I see that “Join our mailing list” is still going on to a second line

i can't duplicate this issue at any screen size. maybe you're looking at an old version? can't debug little stuff like this right now, so just try to hang in there i guess.

rperlin-ela commented 3 years ago

i can't duplicate this issue at any screen size. maybe you're looking at an old version? can't debug little stuff like this right now, so just try to hang in there i guess.

Ok, private window (deploy) and I see it everywhere bigger than mobile

are there really going to be 88 Asian languages? my thought was that the numbering would start at 1 for each continent, not the whole set.

True

it's not a Page. you have to click Projects on left side:

I don't see Projects (or Languages) at all when I go to Appearance > Menu. Again, sorry if I'm missing something basic

Screen Shot 2021-05-21 at 1 47 42 PM
abettermap commented 3 years ago

on this page for example, https://deploy-preview-10--ela-website-j-dev.netlify.app/latest/2021 , this is how i see it from as small as my browser will go all the way up to 2500px or something:

image

if that's not what you're seeing then we're either not looking at the same thing orrrr i have no idea.

I don't see Projects (or Languages) at all when I go to Appearance > Menu. Again, sorry if I'm missing something basic

ah, try Screen Options in top-right! mine looks like:

image

abettermap commented 3 years ago

Ok, private window (deploy) and I see it everywhere bigger than mobile

oh you're on SAFARI. ok i can reproduce it, will look into it

abettermap commented 3 years ago

holy cow, 82 commits 😆

@rperlin-ela i'd like to merge this after you give the deploy i just pushed a quick skim. you're pretty much up to speed except for those last bits i threw into #19.

once we merge this i should be past the more difficult tasks in #18. i'm traveling next weekend but hopefully i can wrap up the remainder the weekend after. i think Home is the big one that's left.

rperlin-ela commented 3 years ago

Got it, looks pretty much rad and ready to me.

Only thing is on Projects landing, it’s confusing to see languages (e.g. Ikota) which don’t have an associated project. Best to axe them altogether

On Jun 13, 2021, at 7:56 PM, Jason Lampel @.***> wrote:

holy cow, 82 commits 😆

@rperlin-ela https://github.com/rperlin-ela i'd like to merge this after you give the deploy i just pushed a quick skim. you're pretty much up to speed except for those last bits i threw into #19 https://github.com/Endangered-Language-Alliance/ela-website/issues/19.

once we merge this i should be past the more difficult tasks in #18 https://github.com/Endangered-Language-Alliance/ela-website/issues/18. i'm traveling next weekend but hopefully i can wrap up the remainder the weekend after. i think Home is the big one that's left.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Endangered-Language-Alliance/ela-website/pull/10#issuecomment-860288978, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5FRTQX5YMIJTY7QXDDTSVARRANCNFSM445L4HTA.

abettermap commented 3 years ago

My bad, good catch. I’m filtering the list but not the map markers.

Will fix when I tackle the Home stuff.

On Sun, Jun 13, 2021 at 7:56 PM rperlin-ela @.***> wrote:

Got it, looks pretty much rad and ready to me.

Only thing is on Projects landing, it’s confusing to see languages (e.g. Ikota) which don’t have an associated project. Best to axe them altogether

On Jun 13, 2021, at 7:56 PM, Jason Lampel @.***> wrote:

holy cow, 82 commits 😆

@rperlin-ela https://github.com/rperlin-ela i'd like to merge this after you give the deploy i just pushed a quick skim. you're pretty much up to speed except for those last bits i threw into #19 < https://github.com/Endangered-Language-Alliance/ela-website/issues/19>.

once we merge this i should be past the more difficult tasks in #18 < https://github.com/Endangered-Language-Alliance/ela-website/issues/18>. i'm traveling next weekend but hopefully i can wrap up the remainder the weekend after. i think Home is the big one that's left.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/Endangered-Language-Alliance/ela-website/pull/10#issuecomment-860288978>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AMNKB5FRTQX5YMIJTY7QXDDTSVARRANCNFSM445L4HTA .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Endangered-Language-Alliance/ela-website/pull/10#issuecomment-860300982, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF6MB3F3NL6TVKGEYPUPYLTSVHULANCNFSM445L4HTA .

rperlin-ela commented 3 years ago

Cool, then if it’s best I’ll merge away — I’ll miss you #10!

On Jun 13, 2021, at 9:14 PM, Jason Lampel @.***> wrote:

My bad, good catch. I’m filtering the list but not the map markers.

Will fix when I tackle the Home stuff.

On Sun, Jun 13, 2021 at 7:56 PM rperlin-ela @.***> wrote:

Got it, looks pretty much rad and ready to me.

Only thing is on Projects landing, it’s confusing to see languages (e.g. Ikota) which don’t have an associated project. Best to axe them altogether

On Jun 13, 2021, at 7:56 PM, Jason Lampel @.***> wrote:

holy cow, 82 commits 😆

@rperlin-ela https://github.com/rperlin-ela i'd like to merge this after you give the deploy i just pushed a quick skim. you're pretty much up to speed except for those last bits i threw into #19 < https://github.com/Endangered-Language-Alliance/ela-website/issues/19>.

once we merge this i should be past the more difficult tasks in #18 < https://github.com/Endangered-Language-Alliance/ela-website/issues/18>. i'm traveling next weekend but hopefully i can wrap up the remainder the weekend after. i think Home is the big one that's left.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/Endangered-Language-Alliance/ela-website/pull/10#issuecomment-860288978>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AMNKB5FRTQX5YMIJTY7QXDDTSVARRANCNFSM445L4HTA .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Endangered-Language-Alliance/ela-website/pull/10#issuecomment-860300982, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF6MB3F3NL6TVKGEYPUPYLTSVHULANCNFSM445L4HTA .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Endangered-Language-Alliance/ela-website/pull/10#issuecomment-860306318, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5HLA7WDD54FBD6LGN3TSVJWTANCNFSM445L4HTA.

abettermap commented 3 years ago

Haha it was a big one!

Merged ✅