Endangered-Language-Alliance / ela-website

Endangered Language Alliance website
1 stars 0 forks source link

Easy style wins #20

Closed abettermap closed 3 years ago

abettermap commented 3 years ago

components on most pages

specific components

bug fixes

layout

abettermap commented 3 years ago

@rperlin-ela

i'd like to do all these on one branch and save the home-specific stuff for another.

footer: link color ok?

i'm fine with it if you are? i tried the red-ish "secondary" color but the purple-ish was better.

rperlin-ela commented 3 years ago

Sounds good, yeah footer link color ok with me

abettermap commented 3 years ago

mobile nav: better link color?

same for that? fine by my as-is.

abettermap commented 3 years ago

and on that mobile note...

mobile nav: btn spacing/centering

how's this?

image

the centering was only supposed to be for the buttons but i kinda like it across the board like that.

rperlin-ela commented 3 years ago

looks good

abettermap commented 3 years ago

kind of struggling in the tabs creativity department. if you have any suggestions, let me know. otherwise this is what i came up with:

image

the drop shadow was nice but it leads to this:

image

if i implement the "fix" to have our shadow cake and eat it too, then it's no longer side-scrollable on mobile. 😞

abettermap commented 3 years ago

wrapping it up for the weekend, holler this week if any feedback on what i pushed!

rperlin-ela commented 3 years ago

will do, looking snazzier!

abettermap commented 3 years ago

k i've tried about 1000 different layouts for the "featured card" thing (on non-Home pages, that is) and really just need to settle on something so let me know what you want for those pages.

A) dedicated row

the easiest one would be to give that card its own row, but i understand your opposition to that since it could make the page look like it's mostly about that single card.

B) shared row, but non-featured card full height

either staggered (not aligned with the card columns in the row below it):

image

or aligned:

image

i don't think either of those look bad myself and would lean towards the staggered option, but i could see how there would be disagreement due to the amount of white space for the shared-first-row card (Events in the screenshot).

C) no whitespace in shared-row card

...but then too much empty space below it:

image

and i haven't been able to find the code magic to fill the empty space if the next card would fit, so that's not an option right now.

Conclusions?

so, any of those look livable to you? keep in mind the summary (excerpt) length in the non-featured cards will vary, so if we went with shared-row option then sometimes it might fill the card nicely.

personally i find inconsistent row and column sizes less pleasing to read and would rather have the whitespace.

abettermap commented 3 years ago

ha! J: 1, CSS: 0. ok more like CSS: 17 but whatever, i still won:

image

ima roll w/that, holler if opposed.

rperlin-ela commented 3 years ago

Looks great!

On Jul 3, 2021, at 7:49 PM, Jason Lampel @.***> wrote:

 ha! J: 1, CSS: 0. ok more like CSS: 17 but whatever, i still won:

ima roll w/that, holler if opposed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

rperlin-ela commented 3 years ago

Any idea why on my end the featured images haven't been coming through?

Screen Shot 2021-07-04 at 1 27 06 PM (2)

abettermap commented 3 years ago

nope, thought i did but it was wrong assumption. something to do with netlify though. it's what i was referring to in:

Images not showing except locally

i'll take a look after i wrap up the layout and card stuff.

abettermap commented 3 years ago

i think i figured it out but won't know until next push.

when you have a chance can you please create a Netlify acct? https://app.netlify.com/signup/email

i'd rather not use Maya's which we're using for the nyc map.

shoot me the credentials via email if you're ok with that, or i can give you instructions but it's mostly one-off stuff and would be easier if just do it.

abettermap commented 3 years ago

hey what did we decide on "Read More" buttons on the non-featured cards? yay or nay? like these guys:

image

they're a bit bland so i wouldn't mind a small button (for consistency if nothing else) if you're ok with that.

rperlin-ela commented 3 years ago

Read More button sounds good