"easy" wins

[abettermap]

closes #20

[abettermap]

@rperlin-ela all good to go on #20! be sure to review all the things in the issue, and definitely test on phone, tablet, all the things. made lots of nitpicky tweaks but they're nice and responsive 👌

i should be able to hit #21 pretty hard tomorrow and hopefully finish it.

[rperlin-ela]

Could it be that for some reason one Featured image still isn't showing up (https://deploy-preview-23--ela-website-j-dev.netlify.app/our-work/maps) while the others all are?

[abettermap]

it comes rolling in eventually. i can look into what the best approach is but the easy fix is just to use a smaller image, you've got quite a monster going:

Next.js should optimize it but i think it's doing it on the fly. confusingly, wp also does its own thing, so i'll have to research which (or both) to use. rule of thumb though is keep it to 1MB or less (and that's still pretty meaty). especially if it's only being used as a thumbnail, or card cover.

[abettermap]

fun fact: i was not including the pre-built HTML pages for any of the regular Pages, e.g. /our-work/revitalization and any /about stuff. sooo maybe next time a build runs and deploys, all the magic will have already done its thing and the image will appear immediately 🤞

[rperlin-ela]

good to know, and I’m guessing that’s the reason some new featured images I just put in aren’t showing yet

On Jul 5, 2021, at 9:06 PM, Jason Lampel @.***> wrote:

fun fact: i was not including the pre-built HTML pages for any of the regular Pages, e.g. /our-work/revitalization and any /about stuff. sooo maybe next time a build runs and deploys, all the magic will have already done its thing and the image will appear immediately 🤞

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Endangered-Language-Alliance/ela-website/pull/23#issuecomment-874390651, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5AMGXIZTYCZMCN3M6TTWJJIZANCNFSM47NAA7OQ.

[abettermap]

Hmm, they should work. I haven’t pushed my build/deploy fix yet, so whatever is in the main site should be loading. Anything on https://ela-website-j-dev.netlify.app

How long are you waiting? The nyc featured image takes a 2-4 seconds for me.

On Mon, Jul 5, 2021 at 9:07 PM rperlin-ela @.***> wrote:

good to know, and I’m guessing that’s the reason some new featured images I just put in aren’t showing yet

On Jul 5, 2021, at 9:06 PM, Jason Lampel @.***> wrote:

fun fact: i was not including the pre-built HTML pages for any of the regular Pages, e.g. /our-work/revitalization and any /about stuff. sooo maybe next time a build runs and deploys, all the magic will have already done its thing and the image will appear immediately 🤞

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/Endangered-Language-Alliance/ela-website/pull/23#issuecomment-874390651>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AMNKB5AMGXIZTYCZMCN3M6TTWJJIZANCNFSM47NAA7OQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Endangered-Language-Alliance/ela-website/pull/23#issuecomment-874408065, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF6MBZIRHZPSK5OMH3UHG3TWJQOLANCNFSM47NAA7OQ .

[rperlin-ela]

Not sure— maybe a little better with the main site than deploy but some still not loading, or very slow, like the one for /our-work/research. Tried to make sure the sizes are not killer. Maybe I messed with the Order (of the pages) in the wrong way.

There’s now a Featured Image for everything under Our Work (except Interpretation) and About Us (except Contact).

On Jul 5, 2021, at 10:28 PM, Jason Lampel @.***> wrote:

Hmm, they should work. I haven’t pushed my build/deploy fix yet, so whatever is in the main site should be loading. Anything on https://ela-website-j-dev.netlify.app

How long are you waiting? The nyc featured image takes a 2-4 seconds for me.

On Mon, Jul 5, 2021 at 9:07 PM rperlin-ela @.***> wrote:

good to know, and I’m guessing that’s the reason some new featured images I just put in aren’t showing yet

On Jul 5, 2021, at 9:06 PM, Jason Lampel @.***> wrote:

fun fact: i was not including the pre-built HTML pages for any of the regular Pages, e.g. /our-work/revitalization and any /about stuff. sooo maybe next time a build runs and deploys, all the magic will have already done its thing and the image will appear immediately 🤞

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/Endangered-Language-Alliance/ela-website/pull/23#issuecomment-874390651>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AMNKB5AMGXIZTYCZMCN3M6TTWJJIZANCNFSM47NAA7OQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Endangered-Language-Alliance/ela-website/pull/23#issuecomment-874408065, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF6MBZIRHZPSK5OMH3UHG3TWJQOLANCNFSM47NAA7OQ .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Endangered-Language-Alliance/ela-website/pull/23#issuecomment-874414742, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5EOOZZBDJEJTFZMFK3TWJS55ANCNFSM47NAA7OQ.

[abettermap]

I turned off Wi-Fi on my phone and they're loading in less than a second for me on pages like  https://ela-website-j-dev.netlify.app/our-work/policy

Kudos for finding an image for Policy 😆

I'll dig in more if still slow on the weekend, but you shouldn't have to go through so much trouble. Next + WP should be doing its thing so possibly something on my end.

[abettermap]

let's pick up the image issue convo in #25 if needed, it's a little buried in the PR.