Endangered-Language-Alliance / ela-website

Endangered Language Alliance website
1 stars 0 forks source link

New font, nav improvements, re-fetching content #7

Closed abettermap closed 3 years ago

abettermap commented 3 years ago

Not sure what the decision was on the body font. did we go with serif? anyway this PR is only Libre Franklin across the board but if decision was serif for body then i'll implement later.

nav is not responsive or burgerized yet but looking/working much better than before. haven't dialed in all styles yet but it's in a good place once we have colors.

content should be closer to dynamic now. i've got different revalidation times set in different scenarios but for the most part by the time you hit Publish in WP, navigate to the corresponding deployed page (if there is one) and hit Refresh, you should see changes.

"if there is one" is hard to explain so the way to get to a NEW page or Lang or Project or whatever, is to go to its landing first, then hit refresh and click the link. e.g. you create "Mandarin", Publish, go to deploy URL, click Languages, and if it doesn't show in the list give it a sec then hit refresh and you should see the link to Mandarin.

the only ones i didn't do that on (assuming i did this properly) are the posts before the current year. so you won't get any real-timeness if you edit stuff from 2014 or something. it has to get triggered on build. hard to explain but if it's a problem i can adjust it.

abettermap commented 3 years ago

@rperlin-ela let me know what you think-ish on:

  1. the approach so far of the nav on desktop
  2. general footer layout
  3. is content appearing after you edit and publish? on new pages/langs/etc. too?
  4. Libre Frank as heading font, button font
  5. reusing the "hero" banner/intro (aka large centered heading with potentially some text or whatever below it) at beginning of most pages/posts.

i don't mind # 5 but will want a Home-specific version perhaps? also i don't necessarily intend to use it for lang or project stuff as those will have a map in the mix. we'll see how it looks but i think it's fine for everything else?

rperlin-ela commented 3 years ago

Yeah, hard to review but I trust you're getting all the ducks in a row.

Libre Frank seems fine to me, but I guess Julia is still getting back to us. By "hero" you mean the thing that now says "Should there be custom title?"? I'm not sure but if you think it'll look good on some of those other pages, with the one on Home a little differentiated, that sounds fine to me. Only question on the footer is whether it looks better not to have that space between hed and subhed (like between "About ELA" and "Team"), not sure.

Not sure what kind of editing I can do at this point. Can find Home among the pages for some reason. I tried editing a post but it didn't appear, I guess that's the build issue.

abettermap commented 3 years ago

By "hero" you mean the thing that now says "Should there be custom title?"

yeah sorry don't ask me why it's called a Hero haha, but in a nutshell at least the space that occupies that area (not likely an image in our case): https://www.optimizely.com/optimization-glossary/hero-image/ . they're certainly overused but they get the job done for intro/titleness.

Only question on the footer is whether it looks better not to have that space between hed and subhed (like between "About ELA" and "Team"), not sure.

are you saying you want the headings to be links, or remove the headings, or just the spacing in general? orange here is spacing:

image

i plugged Libre Frank into a well-used tool to generate the spacing and font-size so it can be standardized more consistently than the cowboying we have in the NYC map, but if it looks off to you then i might have to tweak the Scale knobs or something.

Not sure what kind of editing I can do at this point.

you should be able to edit everything i believe.

Can find Home among the pages for some reason.

sorry, i renamed the title so it'll show on the actual home page. you can always tell if you look for Front Page next to it:

image

obvi feel free to call it whatever you want, i was just trying to avoid ELA or the tagline as the Home Hero text.

I tried editing a post but it didn't appear, I guess that's the build issue.

no it's working. wonder if you were trying old deploy? regardless, i tested both creating and editing a post and saw my changes after Refresh on both:

image

for blog posts you'll be able to view them using the same URL suffix for both, e.g. /latest/2021/testing in my example:

btw i doubled down on the 'derna today so might be incommunicado tomorrow if it hits me like it's hit others, but we shall see!

abettermap commented 3 years ago

also Re: Fonts, the libre as headings + noto serif body doesn't look terrible:

image