EndangeredMassa / npub

publisher for node.js projects
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Only call verify after prep and tests are complete #10

Closed abloom closed 9 years ago

abloom commented 9 years ago

Calling verify at the beginning and then after the prep steps is a waste of cycles. By delaying the call to verify until after the tests are run we also take advantage of any pre/post tests tasks added to the package.json.

We found that calling verify immediately conflicted with our release process:

  1. clean (remove node_modules and lib)
  2. setup (npm install)
  3. npub publish X

Calling verify immediately caused it to fail since our checkout was dirty (missing lib contents). Part of our test process is to build the coffee. By verifying the git status after prep and test we cover all our bases.

abloom commented 9 years ago

closing in favor of #11