search

Ender-Development / Embers-Extended-Life

Continuation of Embers Rekindled, a dwarven magic mod for Minecraft 1.12.2.
https://curseforge.com/minecraft/mc-mods/embers-extended-life
MIT License
8 stars 5 forks source link

Soot integration/fixes ? #1

Closed Primitive-Human closed 6 months ago

Primitive-Human commented 9 months ago

Browsed CF to look at new uploads and found this gem of a unofficial port, which is very nice for 1.12.2.

I see you have integration of the Embers addons (like Soot?) planned. Would you also fix the Crafttweaker support issues for those addons?

Through asking around it seems one of the CT methods for this addon is broken, so I cannot make full use of the brewing system in this addon with my own custom potions.

MasterEnderman commented 9 months ago

Yep, we plan to incorporate most of the current embers addons over time, which don't get any updates anymore. This of course includes soot. Thank you for pointing out the issue, we'll definitely gonna fix this issue, when we get to it, right now we're working making the mod a bit more modular if someone doesn't want one of the addons and wants to disable it. Once we can start with integrating the addons, we'll go over the bugtrackers and see what we can fix.

Klebestreifen commented 9 months ago
Primitive-Human commented 7 months ago

Going over my mods list, two more things should be considered:

  1. CraftTweaker integration: will the current methods on the CraftTweaker docs be kept the same, updated or deprecated in favor of groovyscript?

  2. MultiBlocked integration: This custom multiblock creation mod lets me use Embers blocks (copper cell, receivers/ejectors, crystal cell etc) as Embers input/output components for use in custom multiblock recipes. Embers Rekindled is currently supported; could I expect EEL to also be supported due to all the refactors going on?

MasterEnderman commented 7 months ago

No worries, when we get to implement support for groovyscript, crafttweaker support will stay as well. Furthermore we don't intend to break compatibility with other mods. (Except with the other embers addons) The refactors we speak about are mostly stuff the normal player won't notice as it's just cleaning up the codebase and restructuring certain features (like the config options) to make them easier to expand in the future.

MasterEnderman commented 6 months ago

The newest curseforge beta merges soot into the base mod and also implements the fix for the crafttweaker integration. https://www.curseforge.com/minecraft/mc-mods/embers-extended-life/files/5118405 Furthermore I made a pull request a few days ago to make multiblocked compatible with both version of embers. The version containing the fix can be found here: https://www.curseforge.com/minecraft/mc-mods/multiblocked/files/5078880