search

Ender-Development / Embers-Extended-Life

Continuation of Embers Rekindled, a dwarven magic mod for Minecraft 1.12.2.
https://curseforge.com/minecraft/mc-mods/embers-extended-life
MIT License
8 stars 5 forks source link

Ingredient NBT Data Support #42

Closed Lenvill-Jarlsen closed 2 months ago

Lenvill-Jarlsen commented 4 months ago

Hello! I'm the main author of the Embers addon Emberforged https://www.curseforge.com/minecraft/mc-mods/emberforged, which endeavors to provide increased cross-mod support for Embers and MineFantasyReforged. I'm in the midst of rewriting the mod to support updates to Minefantasy, and to switch to supporting the Embers Extended Life version of the mod.

The main difficulty I've encountered putting this together is the absence of NBT data recognition from Embers. MineFantasyReforged uses a system of NBT tags to define what materials its items are made of, and currently Embers tile entities can't distinguish between a Minefantasy plate made of tin from a Minefantasy plate made of mithril. Having base support for recognizing the difference between items with different NBT tags would be immensely helpful for development (as otherwise I will have to learn how to use mixins and implement NBT support that way).

Three cheers for all active mod development for 1.12.2!

MasterEnderman commented 3 months ago

Just letting you know that with version 1.24.1 the alchemy tablet supports ingredients with nbt data. I tested this with my GroovyScript support (the test file can be found under the examples directory), so this should hopefully work for you as well. If you have any other machine in mind that could benefit from it, please let me know.

Lenvill-Jarlsen commented 2 months ago

This is great to hear! The other machine I was hoping for support for was the melter, other than that I have been able to get most machines working. Thanks for the awesome work!

MasterEnderman commented 2 months ago

The melter should be much easier to implement then the exchange table as I don't have to deal with multiple inputs while also outputting a fluid instead of another item. I'll get to it once I'm back from my holidays.

MasterEnderman commented 2 months ago

with version 1.24.2 NBT support for both machines should work fine. If you encounter anything else feel free to open another issue.