EndlesNights / ambientdoors

Ambient Doors module for Foundry VTT - adds easily customization hocks for sounds effects that all user can hear when interacting with doors.
GNU General Public License v3.0
7 stars 3 forks source link

Update for v11? #22

Open GambetTV opened 1 year ago

GambetTV commented 1 year ago

I know v11 allows for some customization of door audio, but they don't give you the option to choose your own sound effects, whereas this module does. However as far as I can tell this module doesn't work in v11 currently. Would be awesome to get an update.

EndlesNights commented 1 year ago

I was planning on retiring this module, but if they haven't included all of its features into core, then I'll get around to updating it.

GorgoPrimus commented 1 year ago

Please consider updating it and adding a way to tell the core door sounds to not play over yours. Right now all doors sound the same at start whether opening, closing, locking, or unlocking - and the only way to change any of those sounds is to go door by door and change them - and I'm not even sure it can cover all the above like yours can. Your module is way better than what they're doing imo. Thanks!

WGuptill commented 1 year ago

After looking into the functionality of v11, while it provides Slightly less functionality, if you go into a door's settings and change the door sound, every door sound apart from the default unselected door sound has different sounds for locking/unlocking/opening/closing doors. To clarify, v11's functionality is quite good, but lacks a small bit of functionality that's present in this module. If possible, this module would benefit from expanding the per-existing UI & options to bring v11 up to the standard that this module set.

BladeFireLight commented 1 year ago

The built in feature is lacking. there is no way to add special sounds. this mode made it easy. There really needs to be a way to set the default sound for all doors and add custom sounds.

Mesk62 commented 1 year ago

Would really love to see an update!

CallMeGuns commented 12 months ago

It's hilarious this isn't a core feature yet. Why no, I don't want my giant metal gates of doom to sound like two plates of metal clanking together.

uniwars commented 12 months ago

+1

Cempres commented 11 months ago

+1

GambetTV commented 11 months ago

To add another detail, another thing this module did that was super helpful that v11 doesn't have is the ability to Alt + Click doors to silently open/close/lock them.

Fridan99 commented 11 months ago

indispensable module in v11.... in fact I am still in v10 for this and 2 other modules. I think it's a great module.

coffiarts commented 11 months ago

To add another detail, another thing this module did that was super helpful that v11 doesn't have is the ability to Alt + Click doors to silently open/close/lock them.

Could it be that a recent update to Foundry 11 has brought exaclty that as a feature? I just ran a quick test, actually it seems that I can silently open/close/lock doors by ALT-clicking them.

Furthermore, I recomming using Monk's Wall Enhancement Mod, which brings some more nice features, both for doors and general wall editing. It is already v11 compatible.

rbl047 commented 8 months ago

+1

BenDunno commented 5 months ago

Is this module dead?

DrMcCoy commented 5 months ago

Unless I'm mistaken, most of what this module does is already done by Foundry VTT V11 itself. Or at least for my use case, that is the case.

Foundry VTT V11 Core:

There is one thing that was missing (again, as far as I noticed), that was propagating "this door is locked" to every user when a single user clicked a locked door. As I said above, Foundry VTT V11 itself already does the propagating for door opening and closing sounds, but not for the "Hey, I tried to open this locked door and failed" one. So I created a small, single-issue module for that: https://foundryvtt.com/packages/door-is-locked-for-everyone

Is there anything else that people are missing?

uniwars commented 5 months ago

Unless I missed something v11 doesn't let you set a default door sound, so default doors has no sounds and you need to manually go in the door settings to choose a sound set

CallMeGuns commented 5 months ago

@DrMcCoy One small point: Ambientdoors offered custom sounds, while V11 currently locks you into a predefined list of sounds. There are now other modules that add this basic functionality, but this module had it too.

SalieriC commented 5 months ago

+1

Red5MT commented 4 months ago

+1