EndlesNights / dnd4eBeta

An implementation of the dnd4e game system for Foundry Virtual Tabletop (http://foundryvtt.com).
https://foundryvtt.com/packages/dnd4e
GNU Affero General Public License v3.0
37 stars 30 forks source link

[Seeking Opinions/Approval] Unify feature/feat item types #397

Open FoxLee opened 3 weeks ago

FoxLee commented 3 weeks ago

Some time ago, when discussing #245, I had the idea of unifying the various "feat" items (raceFeats, classFeats, pathFeats, destinyFeats, feat) into a single item that could also accommodate monster/hazard traits. I never heard any replies from fellow devs on that particular idea, so I'm going to bug you all for comment here.

My proposal is that, since they all have near-identical fields and implementation, I would like to collapse these all into a single "feature" item with a type selector for Class/Race/Path/Destiny/Background/Theme/Feat/Trait/Other. Since the classFeats additional parameters seem to be vesitigal 5e organs, the only meaningful difference between any of these items right now is whether they have an associated level and/or class/race/source—so it makes great sense to me to merge them. I would also add a property to denote aura traits (not to automate them, since that's the realm of effects, but rather to display on sheet).

I know this is a bunch of work that's broadly unnecessary, but I also would really like to see it happen. Which is why I'm suggesting I will take it on myself! So, my questions to fellow devs are:

draconas1 commented 3 weeks ago

I thought I had commented on this in the previous thread, I'm good with it.