Poor Plugin Support - Githubissues

EndlessSkyCommunity / -Omnis

The leading all-content plugin for Endless Sky, with a greater feature set than most.

GNU General Public License v3.0

28 stars 9 forks source link

Poor Plugin Support #68

Closed mOctave closed 1 week ago

mOctave commented 2 weeks ago

Omnis is great for vanilla, but it doesn't work very well with plugins. Specifically, there's two big improvements that could be made

Documentation, in the form of a list of shipyards/outfitters and description, to show plugin authors where to put their ships and outfits. Probably also a guide on how to connect a custom system up with Omnis.
New "plugin" sales that are empty by default but can be expanded by plugins. Of course, you could go further and include some plugin content by default, but I think those two points are all that's necessary. Also, am I going gradually insane, or did Omnis used to have separate plugin sales?

TheGiraffe3 commented 2 weeks ago

New "plugin" sales that are empty by default

How do you mean? Adding an empty shipyard/outfitter called plugin?

Also, am I going gradually insane, or did Omnis use to have separate plugin sales?

I'm not sure. I don't think so.

mOctave commented 2 weeks ago

How do you mean? Adding an empty shipyard/outfitter called plugin?

More "human plugin" / "korath plugin" etc. Creating an empty plugin shipyard/outfitter to match each standard one.

TheGiraffe3 commented 1 week ago

~~I guess my main problem with that would be players not being able to tell what outfits are vanilla and what outfits are not.~~

Actually, I suppose it would be possible to make it a setting.

TheGiraffe3 commented 1 week ago

New plugin sales that are empty

This is what I get when I try. I'm not sure what I could add to those. Maybe the Caster/a developer outfit?

DarcyManoel commented 1 week ago

It would be useful for the main game to have a indication on outfits if they are plugin content that show where they come from. Maybe an issue to be opened in Endless Sky.

TheGiraffe3 commented 1 week ago

I believe that's been discussed before. Zitchas didn't like the idea, because it breaks immersion.

It would be though.

TheGiraffe3 commented 1 week ago

Alright, PR is up.

Have you got any ideas for the text on the wiki page?

mOctave commented 1 week ago

Maybe a new page for plugin compatibility? I think the things to mention would be:

Where to find the arena script (the Arena page is kind of vague)
A list of the different plugin sales that are supported
Any best practices (for example, I found out five minutes ago that plugins are supposed to define their own systems and arenas)

TheGiraffe3 commented 1 week ago

I'll work on the others, but I don't know what the arena script is either, so it would be nice to get input from Darcy on that.

DarcyManoel commented 1 week ago

I'll work on the others, but I don't know what the arena script is either, so it would be nice to get input from Darcy on that.

https://darcymanoel.github.io/Endless-Sky-Lists/

Upload data to this website and use the options on the left to generate the data.

For vanilla, Omnis Arena and Omnis Arena Ships are relevant. For plugins, Omnis Arena Filtered and Omnis Arena Ships are relevant.

TheGiraffe3 commented 1 week ago

Here's the wiki page. I believe that should be everything. https://github.com/EndlessSkyCommunity/-Omnis/wiki/Plugin-Support