EndlessVanguard / bitcoin-remunerate-api

A scheme for trustless, decentralized, anonymous, remuneration for content creators.

1 stars 0 forks source link

Transaction cleanup #23

Open mattgstevens opened 8 years ago

mattgstevens commented 8 years ago

This flow is a little messy, would like to clean it up

fromheten commented 8 years ago

Martins todo notes

Current problems

Unclear what everything in transaction.js is doing - we wrote it in an exploratory phase but now when we know how things should work we can have it simpler. I think we can remove a lot of code.
Bad test coverage - since the bitcoin-js is OOP and not data-driven, it's not simple to test without mocking and such. But we need to test, especially the transaction building function.
Goals of the module

The transactions we do are payouts to content creators as well as ourselves. So the function payoutContent is the most important.

My little todo list of fixes

[x] Remove fetch.inputsList. That function made sense before we had a Invoice record, but now it's just unclear. Less is more.
[x] The vocabulary is outdated - we have settled on some words such as "Invoice", "Content" etc. At the moment the names in transaction.js are not coherent.
[x] Maybe instead just rewrite the whole thing - We need a payoutContent function(contentId).

fromheten commented 8 years ago

When we merge #35 I think this should be closed - am I right @mattgstevens ?

mattgstevens commented 8 years ago

@fromheten agreed! this cleanup has been great for our understanding and the code shows that IMO :D

fromheten commented 8 years ago

Reopening as #35 is not merged. We still have not fixed this.

mattgstevens commented 8 years ago

35 was superseded by #44

Last I looked at this I was able to succesfully run payouts; is there something blocking #44 from being merged?

fromheten commented 8 years ago

I don't remember now, but I don't think it works does it?

mattgstevens commented 8 years ago

When I made this branch it was because it was working and included the extra changes from #35.

Did you have time to pay yourself back since you got the redis snapshot? Think that would be a good test and you could have the bits of coins back into a wallet you control

On 19 Jul 2016, at 06:03, Martin Josefsson notifications@github.com wrote:

I don't remember now, but I don't think it works does it?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

fromheten commented 8 years ago

Digging into the code again... Fun, but feels weird after not having coded since April!! Time spend outside of the editor is a waste of time ;-).

I tried transacting from a restored DB dump - unsuccessfully. Here are my notes: https://gist.github.com/fromheten/38546ded9df089c65618d7519f61f680