Public TODO list

[EndlesslyFlowering]

overall:

• [ ] add guides for every shader
  • [ ] hdr_analysis
  • [ ] tone_mapping
  • [ ] inverse_tone_mapping
  • [ ] scrgb_trc_fix
  • [ ] hdr_black_floor_fix
• [ ] add test shader
• [ ] add gamut expansion shader
  • [ ] add it to tone mapping and inverse tone mapping shaders

colour_space:

• [x] clean up after the asfloat changes (some namespaces aren't needed anymore)

hdr_and_sdr_analysis:

• [ ] add detection of the ReShade version and error out if it's too old
• [x] redo font atlas texture
  • [x] add font sizes down to 13
• [x] add CIE diagram textures that are 50% in size (for Steam Deck)
• [ ] create the following textures on the fly:
  • [x] waveform scale
  • [x] needs additional font atlas (squeeze it into the other font atlas)
  • [ ] heatmap scale
  • [ ] colour space scale
• [x] add auto detection for the size of all analysis elements (font, CIE diagram, histogram, etc)
• [ ] show cursorCLL and cursorCSP at cursor position
• [x] add back RGB values from cursor
• [x] add back a few more digits for maxCLL (2?), avgCLL (1?), minCLL (1) and cursorCLL (1)
• [x] improve consistency of updating the CLL and CSP values for the overlay
• [x] add active area setting
  • [x] add toggle for active area setting
• [x] pull out all analysis techniques into single files because it's too cluttered
• [x] find a better way to ignore values near black for the csp detection
  • compare source against conversion to the test CSP maybe? will not be "fixed"
• [x] disabling some features breaks some visualisation features
  • csp map doesn't work without csp percentages for example
• [x] properly blend below overlayed elements
• [x] improve vertex shader for clearing the brightness histogram with barebones Vertex shader?
• [ ] add namespace for UI
• [x] add separate pixel/compute shader for combining the colour space outlines?
• [x] fix CIE 1931 diagram texture offset (forgot to change something the last time I recreated the textures)
• [x] consolidate the CIE diagram textures
• [x] remove "DISPATCH_DOESNT_OVERFLOW"
• [x] use atomic ops for max/avg/minCLL and other compute shaders
  • remove dispatch overflow check in the process
  • AdressU/V/W = BORDER; you can't set the BORDER value (yet?) but it's float4(0,0,0,0) by default (https://github.com/crosire/reshade/blob/5c8b8f0993a46fcd2f471181b002fb7f549c33c5/source/runtime.cpp#L2371-L2374)
  • out of texture area load will return float4(0,0,0,0) too (https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-to-load) (does it have a performance penalty?)
  • 64 threads
  • [x] performance testing
• [x] use direct conversion from source csp (scRGB or HDR10) to test csp for colour space detection instead of converting to XYZ first and then to the test csp
• [x] add SDR analysis
  • [x] add text indicator for what analysis is active (SDR 2.2/2.4/sRGB, HDR10, scRGB HDR)
• [x] add vertex+pixel shaders specifically for drawing parts of the overlay not worth to do performance wise
• [x] add vertex+pixel shader for drawing the histogram into the scale and one for the max nits and min nits line (maybe needs workarounds...) not worth to do performance wise

colour_space:

• [x] rewrite extended transfer/gamma functions with abs
  • [x] needs performance testing (up to 0.003 ms improvement depending on GPU load)
• [x] make "template" for PQ<->Linear in the hopes of getting vectorisation
  • [x] needs performance testing
• [ ] look into other functions that might be "templateable"

filmgrain:

• [x] use "asfloat" for all float variables
• [x] implement vertex shader for optimisation not worth to do
• [ ] add namespace for UI

hdr_black_floor_fix:

• [ ] add chroma adjustment from BT.2390 too? maybe as option only
  • I think I already tried this and it caused issues
• [x] use BT.709<->LMS matrices instead of BT.2020<->LMS matrices if possible
  • [x] needs performance testing (microscopic improvement)
• [x] add option to do the SDR black floor emulation just on black levels
• [x] add branching to only do the minimum needed conversions

map_sdr_into_hdr:

• [ ] add namespace for UI

inverse_tone_mapping:

• [ ] implement vertex shader for optimisation
• [ ] general clean up needed
• [ ] finish BT.2446 Method C
• [ ] LUT based inverse tone mapping ( https://ieeexplore.ieee.org/document/8610020 )
  • this includes implementing it for BT.2390

tone_mapping:

• [ ] add ability to highlight tone mapped pixels
• [ ] add ST-2094-10 tone mapper (HDR10+)
• [ ] add ST-2094-40 tone mapper (HDR10+)
• [ ] add black point adaption for every tone mapper
• [ ] do maxCLL calc in quarter res? and with atomic ops
• [x] remove excessive checks for colour space setup (now each tmo does the needed conversions)
• [ ] add option to do BT.2446A as post adjustment of BT.2390/Dice
• [x] use BT.709 RGB->LMS matrix instead of rotating into BT.2020?
  • [ ] needs performance testing
• [ ] make Dice use the same knee function as BT.2390?
• [ ] put oneMinusKneeStart into the vertex shader?
• [ ] LUT based tone mapping
  • [x] look into perceptual scaling in LUTs (these are called shaper LUTs)

[ABDX80]

Are we still getting some Test Patterns to fine tune the shaders?

P.S. Phenomenal Mod.

[EndlesslyFlowering]

P.S. Phenomenal Mod.

thanks! :)

Are we still getting some Test Patterns to fine tune the shaders?

not sure what you mean exactly?

[ABDX80]

The 'Test Patterns' you mentioned on "Plasma TV for Gaming" YT channel. Test Patterns that we could use in-game to fine tune HDR properly. For black levels, highlights etc... @EndlesslyFlowering

[EndlesslyFlowering]

The 'Test Patterns' you mentioned on "Plasma TV for Gaming" YT channel. Test Patterns that we could use in-game to fine tune HDR properly. For black levels, highlights etc... @EndlesslyFlowering

Ah that. After I finish all the Steam Deck related stuff I can expose it (it's basically done :) )

[ABDX80]

Hello again! Could you please add the functionality so that the HDR Analysis tool works for Windows 11 AutoHDR. This'll help a lot. Since AutoHDR even have raised black levels. @EndlesslyFlowering

[EndlesslyFlowering]

Hello again! Could you please add the functionality so that the HDR Analysis tool works for Windows 11 AutoHDR. This'll help a lot. Since AutoHDR even have raised black levels. @EndlesslyFlowering

Impossible.

[dakerano66]

@EndlesslyFlowering I would like to know what is SDR TRC fix. Something would be wrong if I use it on HDR?

I am using it on HDR because seems to fix the black floor automatically

Also, what is input lower gamma? If I enable my tv's black frame insertion which dimms the picture I could increase this value to get as bright as it was without bfi. Doing so, the perfect black does not change, the color clipping and white clipping seems correct, but I am unsure if it is washing out the picture or crashing midtones, or something. I dont know which test patern should I use as reference to check for that. HDR analisis tool cant be used as reference, because the spectrum does not change when enabling BFI altought the picture is obvioulsy darker (means blacks and midtones spectrum should be lower, but it is not reflected)

Thank you for your work.

[EndlesslyFlowering]

@EndlesslyFlowering I would like to know what is SDR TRC fix. Something would be wrong if I use it on HDR?

I am using it on HDR because seems to fix the black floor automatically

it's in the naming: SDR only

Also, what is input lower gamma?

I assume you mean "input power gamma": you can choose between sRGB and power gamma, sRGB is not really a gamma but it simplifies usage of the terms. 2.2, 2.4 or 2.6 are all "power gammas" as in x to the power of 2.2 or 2.4 (x^2.2). 2.2, 2.4 and 2.6 are values that are used in real world contexts, the shader allows for whatever value you want though.

If I enable my tv's black frame insertion which dimms the picture I could increase this value to get as bright as it was without bfi. Doing so, the perfect black does not change, the color clipping and white clipping seems correct, but I am unsure if it is washing out the picture or crashing midtones, or something. I dont know which test patern should I use as reference to check for that. HDR analisis tool cant be used as reference, because the spectrum does not change when enabling BFI altought the picture is obvioulsy darker (means blacks and midtones spectrum should be lower, but it is not reflected)

I guess you are looking for gamma adjustment of the lower range? I am planning on creating such a shader in the future (no estimates). SDR TRC fix is definitely the wrong one for this.

[aron7awol]

I see "add back RGB values from cursor" marked as completed on the hdr_and_sdr_analysis list, but as far as I can tell this functionality to show the RGB values of the cursor does not currently exist? Did it exist in an older version?

[EndlesslyFlowering]

I see "add back RGB values from cursor" marked as completed on the hdr_and_sdr_analysis list, but as far as I can tell this functionality to show the RGB values of the cursor does not currently exist? Did it exist in an older version?

when something is marked as completed here, it's pushed to the github master. which does not mean that there is a release yet.

in this case there is a pre-release

[ABDX80]

Greetings,

Is the 'roll off stopping point' in black floor lowering shader's functionality altered? In earlier versions, the default value was '10.0nits' I'd loved using it on 1.0nit. It would work brilliantly. But now with newer version of this shader, if I choose 1.0 or 10.0nits the screen goes completely dark? I have to now use either 1000.0nits or 10000.0nits why is that?

A brief explanation will help a lot on how to use it properly.

Thanks! @EndlesslyFlowering