search

EndlesslyFlowering / ReShade_HDR_shaders

ReShade shaders focused on HDR analysis, (post) processing and (inverse) tone mapping.
GNU General Public License v3.0
219 stars 6 forks source link

Shader not compiling in scRGB HDR when colour space is not set #28

Closed EndlesslyFlowering closed 5 months ago

EndlesslyFlowering commented 5 months ago

I also have a similar problem. Since 2024.06.02, lilium__hdr_and_sdr_analysis failed to complie with Assassin's Creed Odyssey, which has no problem with 2024.04.18. Here is ReShade.log

_Originally posted by @onenowy in https://github.com/EndlesslyFlowering/ReShade_HDR_shaders/issues/27#issuecomment-2148839453_

EndlesslyFlowering commented 5 months ago

@onenowy please check the latest master here

onenowy commented 5 months ago

No compiling error, but every hdr related shaders are not working. ReShade.log

EDIT: It's also not working with https://github.com/EndlesslyFlowering/AutoHDR-ReShade on hi-fi rush with latest master (compiling error with 2024.06.02), but it's working with 2024.04.18. hi-fi-rush-ReShade.log

EDIT2: setting CSP_OVERRIDE to CSP_SCRGB allows both game to work with latest master.

EndlesslyFlowering commented 5 months ago

No compiling error, but every hdr related shaders are not working. ReShade.log

EDIT: It's also not working with https://github.com/EndlesslyFlowering/AutoHDR-ReShade on hi-fi rush with latest master (compiling error with 2024.06.02), but it's working with 2024.04.18. hi-fi-rush-ReShade.log

EDIT2: setting CSP_OVERRIDE to CSP_SCRGB allows both game to work with latest master.

Yes that was an intentional change.

Glad that it works again :)

With the newest version of the AutoHDR add-on the colour space should be set correctly though.