search

EndlesslyFlowering / ReShade_HDR_shaders

ReShade shaders focused on HDR analysis, (post) processing and (inverse) tone mapping.
GNU General Public License v3.0
197 stars 6 forks source link

hdr_black_floor_fix: roll off stopping point not working as expected anymore #34

Open EndlesslyFlowering opened 2 months ago

EndlesslyFlowering commented 2 months ago

Greetings,

Is the 'roll off stopping point' in black floor lowering shader's functionality altered? In earlier versions, the default value was '10.0nits' I'd loved using it on 1.0nit. It would work brilliantly. But now with newer version of this shader, if I choose 1.0 or 10.0nits the screen goes completely dark? I have to now use either 1000.0nits or 10000.0nits why is that?

A brief explanation will help a lot on how to use it properly.

Thanks! @EndlesslyFlowering

_Originally posted by @ABDX80 in https://github.com/EndlesslyFlowering/ReShade_HDR_shaders/issues/10#issuecomment-2253750676_

EndlesslyFlowering commented 1 month ago

I can't replicate this in HDR10 or scRGB. I also checked the code and everything is fine...

try deleting all files you have from this repo and downloading the latest release.

ABDX80 commented 2 days ago

I just tried it with a fresh download of the latest repo as suggested, same issue persisted.

Anyhow, I was able to pinpoint the culprit. This problem only happens when you use 'roll off stopping point' in conjunction with 'SDR Black Floor Emulation' enabled, specifically when 'processing color space' is set to 'BT.2020', this does not cause a problem if it is set to 'BT.709' or 'DCI-P3' presets.

So please try it this way, I'm sure it's going to be evident. @EndlesslyFlowering

EndlesslyFlowering commented 1 day ago

I just tried it with a fresh download of the latest repo as suggested, same issue persisted.

Anyhow, I was able to pinpoint the culprit. This problem only happens when you use 'roll off stopping point' in conjunction with 'SDR Black Floor Emulation' enabled, specifically when 'processing color space' is set to 'BT.2020', this does not cause a problem if it is set to 'BT.709' or 'DCI-P3' presets.

So please try it this way, I'm sure it's going to be evident. @EndlesslyFlowering

OK, that got me on the right track. Thank You!

fix until next release: hdr_black_floor_fix.zip goes into folder lilium__include