search

Eneco / landscaper

Deprecated. Takes a set of Helm Chart references with values (a desired state), and realizes this in a Kubernetes cluster
Apache License 2.0
336 stars 31 forks source link

landscaper update does not update pods of ReplicaControllers or DaemonSets #79

Open philipbjorge opened 7 years ago

philipbjorge commented 7 years ago

landscaper update does not update pods of ReplicaControllers or DaemonSets.

Ran into this while updating environment variables in a daemonset.

It looks like this is supported by helm with the --recreate-pods argument which is a temporary workaround in place until kubernetes upstream handles it.

It seems like this option would best be supported in the landscape definition? I'm thinking, I only want to use this argument on specific, impacted charts (e.g. logspout) especially since it does not do a soft restart right now -- https://github.com/kubernetes/helm/issues/1702

A workaround today is to build in hooks to the chart to handle recreating it's pods.

https://github.com/kubernetes/helm/pull/1648

Thoughts on a plan of action?

philipbjorge commented 7 years ago

@rollulus -- Any opinions on how this should be done?