Enekwestanley / Awesome-Book

3 stars 0 forks source link

Open Kelvin-Ben opened 2 years ago

Kelvin-Ben commented 2 years ago

3

your project has been implemented well-using javascript and that's great work.
I also observed that time was also added to the page and that's great.
I will like to mention that, it is important to delete the feature branch after you have merged so that any other person who clones your project can have an easy time going through the project.

Alhajideen commented 2 years ago

Congratulation guys 👍 ,

Your code is clean, well organized, and easy to read. I think it will be nicer if you can add the livelink to the readme also.

Nice one guys 💯

OscarFMdev commented 2 years ago

Your SPA is working fine, your code is clear and understandable, however, I think you could improve some things:

You can give more descriptive names to your branches, that way you and your user know what you are working on.
You could create variables for the pages that you are showing and hiding that way you can be closer to the DRY principle.
I think is a better practice to call your classes with the first letter in upper case.