search

Enerccio / ewlc

Wayland compositor library - extended
MIT License
20 stars 3 forks source link

[CLOSED] Provide hooks for overriding default behavior #15

Closed Enerccio closed 7 years ago

Enerccio commented 7 years ago

Issue by Cloudef Friday Feb 27, 2015 at 13:21 GMT Originally opened as https://github.com/Cloudef/wlc/issues/7

Most useful drawing for example view borders, background, or any other custom behavior where it makes sense.

Enerccio commented 7 years ago

Comment by SirCmpwn Thursday Aug 06, 2015 at 03:07 GMT

:+1:

Would particularly like to override borders. I would say that the things you mentioned (border, background) are both probably the domain of the consumer of this library, and don't really belong in the library itself.

Edit: that's not to say that wlc shouldn't provide facilities to the consumer for actually doing those things, I think that's fine and actually quite nice. But providing a default behaviour is probably not great.

Enerccio commented 7 years ago

Comment by Cloudef Thursday Aug 06, 2015 at 14:40 GMT

Background most likely moves to be a wayland client. Drawing borders, focus or other view related things and effects though makes sense inside compositor. Wlc will not provide facilities for drawing itself, you must choose library yourself for that.

Enerccio commented 7 years ago

Comment by SirCmpwn Thursday Aug 06, 2015 at 14:41 GMT

That seems fine. I'm just looking for a way to get rid of the default borders and close/max/min buttons and so on. The background as a wayland client makes sense, too.

Enerccio commented 7 years ago

Comment by Cloudef Thursday Aug 06, 2015 at 15:05 GMT

For those, you can't get rid of those until somebody stands up with a protocol extension for that. Client draws those borders, and currently there is no way to communicate between compositor/client to not do that.

Enerccio commented 7 years ago

Comment by SirCmpwn Thursday Aug 06, 2015 at 15:06 GMT

Oh, so those aren't wlc's domain?

Enerccio commented 7 years ago

Comment by Cloudef Thursday Aug 06, 2015 at 15:08 GMT

Nope, wlc borders would be the server-side borders. The thing Weston does for Xwayland clients. Weston test applications and GTK draw client side borders.

Enerccio commented 7 years ago

Comment by SirCmpwn Thursday Aug 06, 2015 at 15:09 GMT

I see. Thanks for clarifying.