Energinet-DataHub / ARCHIVED-geh-charges

Apache License 2.0
7 stars 3 forks source link

ChargeCommand - Update NamingScheme as per guidebook #116

Open PerLysemose opened 3 years ago

PerLysemose commented 3 years ago

TimeBoxed story.

In the given amount of time, adjust our ChargeCommand as much as time allows, considering the following:

AC1: After our refactor, we must still be able to successfully validate and persist addition of charges AC2: After our refactor, we must still be able to reject commands failing input validation AC3: After our refactor, we must still be able to reject commands failing business validation AC4: Update the charge dictionary as needed by the refactoring - https://github.com/Energinet-DataHub/green-energy-hub/blob/main/docs/dictionary-and-concepts/dictionary-charges.md AC5: Postman is updated after the refactor of the ChargeCommand model

PerTHenriksen commented 3 years ago

Link to engelsk navngivning på forskrifter: https://en.energinet.dk/Electricity/Rules-and-Regulations/Archive-Market-Regulations

prtandrup commented 3 years ago

AC#5: Postman Scripts were updated to reflect the new naming/structure of the ChargeCommand. image Example for Create Fee: { "Document": { "Id": "DocId{{$isoTimestamp}}", "CreatedDateTime": "{{$isoTimestamp}}", "IndustryClassification": 23, "DocumentType": 10, "Sender": { "Id": 37, "MRid": "8100000000030", "Name": "Grid Operator 3", "Role": 0 }, "Recipient": { "Id": 1, "MRid": "5790001330552", "Name": "Hub", "Role": 0 } }, "ChargeOperation": { "Id": "OpId{{$isoTimestamp}}", "EndDateTime": null, "Status": 2, "LastUpdatedBy": "LastUpdatedByPostman", "BusinessReasonCode": 18, "ChargeId": "ChargeId01", "ChargeName": "Charge Fee Name", "Type": 1, "ChargeOwner": "8100000000030", "Resolution": "P1D", "TaxIndicator": false, "VatClassification": 1, "ChargeDescription": "The charge description", "StartDateTime": "2021-07-31T22:00:00Z", "Period": { "Points": [ { "Position": 1, "Price": 100.001, "Time": "2021-07-31T22:00:00Z" } ] } } }

prtandrup commented 3 years ago

AC#4: Both PO and SME (Irene) are OK with the new naming convention. The dictionary in the GEH repo is being updated with this PR