Energinet-DataHub / ARCHIVED-geh-charges

Apache License 2.0
7 stars 3 forks source link

refac: Environment variables in appsettings #1805

Closed ShaBloze closed 1 year ago

ShaBloze commented 1 year ago

Description

Right now we have to put environment variables into launchSettings.json to start our WebApi local. We would like to have those variables in the appsettings.

References

codecov[bot] commented 1 year ago

Codecov Report

Merging #1805 (5c6469b) into main (0ba2b0f) will increase coverage by 49.69%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #1805       +/-   ##
===========================================
+ Coverage   34.02%   83.72%   +49.69%     
===========================================
  Files          24      451      +427     
  Lines         485     7930     +7445     
  Branches       22       22               
===========================================
+ Hits          165     6639     +6474     
- Misses        305     1169      +864     
- Partials       15      122      +107     
Flag Coverage Δ
business 86.95% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nEnergyHub.Charges.WebApi/QueryApiConfiguration.cs 93.75% <100.00%> (ø)
...es/source/GreenEnergyHub.Charges.WebApi/Startup.cs 98.61% <100.00%> (ø)
...rgeLinks/Handlers/ChargeLinkEventPublishHandler.cs 100.00% <0.00%> (ø)
...nHost/MessageHub/OutboxMessageProcessorEndpoint.cs 100.00% <0.00%> (ø)
...Hub/MessageHub/AvailableDataNotificationFactory.cs 100.00% <0.00%> (ø)
...dationRules/SenderIsMandatoryTypeValidationRule.cs 100.00% <0.00%> (ø)
...rgeInformationCommands/ChargeCommandNullChecker.cs 100.00% <0.00%> (ø)
...rastructure.Core/Cim/Charges/TaxIndicatorMapper.cs 100.00% <0.00%> (ø)
...s/ChargeLinksCommands/ChargeLinksCommandFactory.cs 100.00% <0.00%> (ø)
...les/ChargeReceipt/ChargeReceiptCimXmlSerializer.cs 95.23% <0.00%> (ø)
... and 419 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication