Energinet-DataHub / ARCHIVED-geh-charges

Apache License 2.0
7 stars 3 forks source link

fix: ChargeMessageType reflects BusinessReasonCode #1834

Closed HenrikSommer closed 1 year ago

HenrikSommer commented 1 year ago

Description

To differentiate between ChargeInformation messages and ChargePrice messages we need to replace DocumentType with BusinessReasonCode as MessageType.

References

codecov[bot] commented 1 year ago

Codecov Report

Merging #1834 (8293112) into main (7ef3d38) will decrease coverage by 0.99%. The diff coverage is 73.33%.

@@            Coverage Diff             @@
##             main    #1834      +/-   ##
==========================================
- Coverage   84.07%   83.07%   -1.00%     
==========================================
  Files         471      449      -22     
  Lines        8214     7977     -237     
  Branches      438       22     -416     
==========================================
- Hits         6906     6627     -279     
- Misses       1218     1225       +7     
- Partials       90      125      +35     
Flag Coverage Δ
business 86.77% <73.33%> (?)
clientlibraries 31.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nEnergyHub.Charges.QueryApi/Model/ChargeMessage.cs 0.00% <0.00%> (-42.86%) :arrow_down:
...ueryApi/QueryServices/ChargeMessageQueryService.cs 90.00% <57.14%> (-2.46%) :arrow_down:
...geInformation/ChargeInformationMessagePersister.cs 100.00% <100.00%> (ø)
...andlers/ChargePrice/ChargePriceMessagePersister.cs 100.00% <100.00%> (ø)
...nEnergyHub.Charges.Domain/Charges/ChargeMessage.cs 100.00% <100.00%> (ø)
...ergyHub.Charges.Domain/Charges/ChargeIdentifier.cs 0.00% <0.00%> (-100.00%) :arrow_down:
...rastructure.Core/Registration/EnvironmentHelper.cs 0.00% <0.00%> (-100.00%) :arrow_down:
...ain/Dtos/Events/MarketParticipantCreatedCommand.cs 14.28% <0.00%> (-85.72%) :arrow_down:
...es.Domain/Dtos/Events/GridAreaOwnerAddedCommand.cs 33.33% <0.00%> (-66.67%) :arrow_down:
...Dtos/Events/MarketParticipantNameChangedCommand.cs 33.33% <0.00%> (-66.67%) :arrow_down:
... and 76 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication