prtandrup commented 1 year ago

Description

A few minor corrections that has been listed on my to do for a while :smile:

[x] Remove MarketParticipantGridAreaUpdatedCommand which is no longer used. Related to ActorRegistry v2.
[x] Clean-up CimXmlSerializers, mostly relevant for ChargeCimXmlSerializer, where all but one element is now mandatory (except terminationDate). CimXmlHelper was refactored so it defaults notNeeded to false, allowed some lines to be deleted in serializers.
[x] Exclude terminationDate in charge information JSON notification, when terminationDate equals charges internal EndDefault.
[x] Correctly use MeteringPointAdministrator.Id in Recipient (MarketParticipantDto) for ChargeLinksCommand originating from the Default Charge Links flow.

References

0000

codecov[bot] commented 1 year ago

Codecov Report

Merging #1842 (f7265f3) into main (a3c8f08) will decrease coverage by 0.13%. The diff coverage is 52.31%.

@@            Coverage Diff             @@
##             main    #1842      +/-   ##
==========================================
- Coverage   84.08%   83.94%   -0.14%     
==========================================
  Files         471      447      -24     
  Lines        8211     7924     -287     
  Branches      438       22     -416     
==========================================
- Hits         6904     6652     -252     
+ Misses       1217     1151      -66     
- Partials       90      121      +31

Flag	Coverage Δ
business	`87.73% <52.31%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...AreaOwnerFromGridAreaOwnerRemovedCommandHandler.cs	`80.00% <0.00%> (+10.00%)`	:arrow_up:
.../ChargeLinks/ChargeLinksCommandReceiverEndpoint.cs	`0.00% <0.00%> (ø)`
...t/ChargeLinks/ChargeLinksEventPublisherEndpoint.cs	`0.00% <0.00%> (ø)`
...geLinks/CreateDefaultChargeLinksReplierEndpoint.cs	`0.00% <0.00%> (ø)`
...geLinkConfirmationDataAvailableNotifierEndpoint.cs	`0.00% <0.00%> (ø)`
...sageHub/ChargeLinkDataAvailableNotifierEndpoint.cs	`0.00% <0.00%> (ø)`
...argeLinksRejectionDataAvailableNotifierEndpoint.cs	`0.00% <0.00%> (ø)`
...harges/ChargeInformationCommandReceivedEndpoint.cs	`0.00% <0.00%> (ø)`
...arges/ChargeInformationMessagePersisterEndpoint.cs	`0.00% <0.00%> (ø)`
...harges/ChargeIntegrationEventsPublisherEndpoint.cs	`0.00% <0.00%> (ø)`
... and 146 more