Energinet-DataHub / ARCHIVED-geh-charges

Apache License 2.0
7 stars 3 forks source link

feat: a validation that checks if there are any points included with a D08 request #1844

Closed x-platformcoder closed 1 year ago

x-platformcoder commented 1 year ago

Description

As the same schema is used for both D08 and D18, there is a cardinality 0..n for priceseries elements, but if the request is a D08 it makes no sence if there is no priceseries elements, so the request will be rejected asynchronous.

References

codecov[bot] commented 1 year ago

Codecov Report

Merging #1844 (a338189) into main (e63a7da) will decrease coverage by 0.71%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1844      +/-   ##
==========================================
- Coverage   84.67%   83.96%   -0.72%     
==========================================
  Files         469      448      -21     
  Lines        8158     7931     -227     
  Branches      433       22     -411     
==========================================
- Hits         6908     6659     -249     
+ Misses       1164     1151      -13     
- Partials       86      121      +35     
Flag Coverage Δ
business 87.74% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ChargePriceOperationInputValidationRulesFactory.cs 100.00% <100.00%> (ø)
...utValidation/ValidationRules/PointsRequiredRule.cs 100.00% <100.00%> (ø)
...Hub/Models/Shared/CimValidationErrorCodeFactory.cs 100.00% <100.00%> (ø)
...ergyHub.Charges.Domain/Charges/ChargeIdentifier.cs 0.00% <0.00%> (-100.00%) :arrow_down:
...ain/Dtos/Events/MarketParticipantCreatedCommand.cs 14.28% <0.00%> (-85.72%) :arrow_down:
...es.Domain/Dtos/Events/GridAreaOwnerAddedCommand.cs 33.33% <0.00%> (-66.67%) :arrow_down:
...Dtos/Events/MarketParticipantNameChangedCommand.cs 33.33% <0.00%> (-66.67%) :arrow_down:
...os/Events/MarketParticipantStatusChangedCommand.cs 33.33% <0.00%> (-66.67%) :arrow_down:
...vents/MarketParticipantB2CActorIdChangedCommand.cs 33.33% <0.00%> (-66.67%) :arrow_down:
....ApplyDBMigrationsApp/Helpers/EnvironmentFilter.cs 0.00% <0.00%> (-62.50%) :arrow_down:
... and 72 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication