x-platformcoder commented 1 year ago

Description

An asynchronous rejection is created for price series messages if the charge does not exist. Until now, an InvalidOperationException was thrown instead

Some cleanup for an obsolete rule is also included.

References

0000

codecov[bot] commented 1 year ago

Codecov Report

Merging #1849 (91ce2a1) into main (1ad8ce6) will decrease coverage by 0.24%. The diff coverage is 95.00%.

@@            Coverage Diff             @@
##             main    #1849      +/-   ##
==========================================
- Coverage   84.40%   84.15%   -0.25%     
==========================================
  Files         468      447      -21     
  Lines        8046     7814     -232     
  Branches      432       22     -410     
==========================================
- Hits         6791     6576     -215     
+ Misses       1170     1110      -60     
- Partials       85      128      +43

Flag	Coverage Δ
business	`87.70% <95.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ndlers/ChargePrice/ChargePriceOperationsHandler.cs	`90.72% <92.30%> (+4.35%)`	:arrow_up:
...hargeLinksCommandBusinessValidationRulesFactory.cs	`100.00% <100.00%> (ø)`
...idationRules/ChargeMustExistOnLinkStartDateRule.cs	`100.00% <100.00%> (ø)`
...lidation/ValidationRules/ChargeDoesNotExistRule.cs	`100.00% <100.00%> (ø)`
...Hub/Models/Shared/CimValidationErrorCodeFactory.cs	`100.00% <100.00%> (ø)`
...ergyHub.Charges.Domain/Charges/ChargeIdentifier.cs	`0.00% <0.00%> (-100.00%)`	:arrow_down:
...ain/Dtos/Events/MarketParticipantCreatedCommand.cs	`14.28% <0.00%> (-85.72%)`	:arrow_down:
...es.Domain/Dtos/Events/GridAreaOwnerAddedCommand.cs	`33.33% <0.00%> (-66.67%)`	:arrow_down:
...Dtos/Events/MarketParticipantNameChangedCommand.cs	`33.33% <0.00%> (-66.67%)`	:arrow_down:
...os/Events/MarketParticipantStatusChangedCommand.cs	`33.33% <0.00%> (-66.67%)`	:arrow_down:
... and 73 more