Energinet-DataHub / ARCHIVED-geh-charges

Apache License 2.0
7 stars 3 forks source link

Remove: `ChargeLinkV2Dto` which was never fully implemented #1853

Closed prtandrup closed 1 year ago

prtandrup commented 1 year ago

Description

This PR removes the never used ChargeLinkV2Dto in both backend and in Charges.Client packages. It was never fully implemented, and later abandoned.

References

codecov[bot] commented 1 year ago

Codecov Report

Merging #1853 (a315c74) into main (0ec3bd6) will decrease coverage by 0.82%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1853      +/-   ##
==========================================
- Coverage   84.69%   83.86%   -0.83%     
==========================================
  Files         470      447      -23     
  Lines        8165     7885     -280     
  Branches      433       22     -411     
==========================================
- Hits         6915     6613     -302     
+ Misses       1164     1151      -13     
- Partials       86      121      +35     
Flag Coverage Δ
business 87.67% <ø> (?)
clientlibraries 31.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s.QueryApi/ModelPredicates/ChargeLinkQueryLogic.cs 80.00% <ø> (-14.92%) :arrow_down:
...ergyHub.Charges.Domain/Charges/ChargeIdentifier.cs 0.00% <0.00%> (-100.00%) :arrow_down:
...ain/Dtos/Events/MarketParticipantCreatedCommand.cs 14.28% <0.00%> (-85.72%) :arrow_down:
...es.Domain/Dtos/Events/GridAreaOwnerAddedCommand.cs 33.33% <0.00%> (-66.67%) :arrow_down:
...Dtos/Events/MarketParticipantNameChangedCommand.cs 33.33% <0.00%> (-66.67%) :arrow_down:
...os/Events/MarketParticipantStatusChangedCommand.cs 33.33% <0.00%> (-66.67%) :arrow_down:
...vents/MarketParticipantB2CActorIdChangedCommand.cs 33.33% <0.00%> (-66.67%) :arrow_down:
....ApplyDBMigrationsApp/Helpers/EnvironmentFilter.cs 0.00% <0.00%> (-62.50%) :arrow_down:
....Domain/Dtos/Events/GridAreaOwnerRemovedCommand.cs 50.00% <0.00%> (-50.00%) :arrow_down:
...rastructure.Core/Registration/EnvironmentHelper.cs 0.00% <0.00%> (-50.00%) :arrow_down:
... and 69 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information