Energinet-DataHub / ARCHIVED-geh-charges

Apache License 2.0
7 stars 3 forks source link

SQL IAM authentication using DbUp.Reboot #1865

Closed kerbou closed 1 year ago

kerbou commented 1 year ago

We are replacing DbUp with a fork called DbUp.Reboot to cater for SQL IAM authentication instead of SQL Auth w/username + password in connectionstrings

Reference: https://app.zenhub.com/workspaces/mighty-ducks---the-outlaws-6193fe815d79fc0011e741b1/issues/energinet-datahub/the-outlaws/660

codecov[bot] commented 1 year ago

Codecov Report

Merging #1865 (918ce13) into main (cca9740) will decrease coverage by 0.42%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1865      +/-   ##
==========================================
- Coverage   84.51%   84.09%   -0.43%     
==========================================
  Files         468      448      -20     
  Lines        8047     7820     -227     
  Branches      432       22     -410     
==========================================
- Hits         6801     6576     -225     
+ Misses       1161     1116      -45     
- Partials       85      128      +43     
Flag Coverage Δ
business 87.62% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plyDBMigrationsApp/Helpers/CustomScriptProvider.cs 87.50% <ø> (+12.50%) :arrow_up:
...ges.ApplyDBMigrationsApp/Helpers/ResultReporter.cs 92.30% <ø> (+7.69%) :arrow_up:
...rationsApp/Helpers/SqlAppAuthenticationProvider.cs 0.00% <0.00%> (ø)
...ges.ApplyDBMigrationsApp/Helpers/UpgradeFactory.cs 84.61% <ø> (+15.38%) :arrow_up:
...nEnergyHub.Charges.ApplyDBMigrationsApp/Program.cs 0.00% <0.00%> (ø)
...ergyHub.Charges.Domain/Charges/ChargeIdentifier.cs 0.00% <0.00%> (-100.00%) :arrow_down:
...ain/Dtos/Events/MarketParticipantCreatedCommand.cs 14.28% <0.00%> (-85.72%) :arrow_down:
...es.Domain/Dtos/Events/GridAreaOwnerAddedCommand.cs 33.33% <0.00%> (-66.67%) :arrow_down:
...Dtos/Events/MarketParticipantNameChangedCommand.cs 33.33% <0.00%> (-66.67%) :arrow_down:
...os/Events/MarketParticipantStatusChangedCommand.cs 33.33% <0.00%> (-66.67%) :arrow_down:
... and 73 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication