Energinet-DataHub / greenforce-frontend

GreenForce monorepo for the DataHub and Energy Origin frontends. Part of Energinet DataHub.

Apache License 2.0

72 stars 13 forks source link

fix(dh): improvements to `query` function #3362

Closed dzhavat closed 2 months ago

dzhavat commented 2 months ago

Description

DataHub

do not complete stream on error by moving catchError operator inside valueChanges
add fetchPolicy on refetch method
add test to verify behaviour. The test show that a query can be recovered from error state when calling refetch. The test DO NOT show that loading Signal is set to true after refetch is called because I couldn't figure out how to set the query in that state. However, this is what happens in the browser.

References

0000

nx-cloud[bot] commented 2 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ae0d49d28a1ac621e6469a1c78c14f9fb0da4128. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

- [`nx run api-dh:build-client`](https://cloud.nx.app/runs/sW2KKruEgr?utm_source=pull-request&utm_medium=comment) - [`nx build app-dh`](https://cloud.nx.app/runs/Rq6p3JkEVS?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.