Energinet-DataHub / greenforce-frontend

GreenForce monorepo for the DataHub and Energy Origin frontends. Part of Energinet DataHub.

Apache License 2.0

72 stars 13 forks source link

refac(watt): refactor watt-field to use signals + more #3367

Closed ManBearTM closed 2 months ago

ManBearTM commented 2 months ago

Closes https://github.com/Energinet-DataHub/greenforce-frontend/issues/3178

I also had to make the component subscribe to statusChanges, since otherwise the isRequired state would not be properly updated when dynamically changing form control validators (yes that is a use case now 😄). Also meant that I could change the component to use OnPush for change detection.

nx-cloud[bot] commented 2 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 11fc9ffc1714eecc9234b8d61e0f4d48a2eef72d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

- [`nx build app-eo`](https://cloud.nx.app/runs/CKQZYjv0pb?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.