Energinet-DataHub / greenforce-frontend

GreenForce monorepo for the DataHub and Energy Origin frontends. Part of Energinet DataHub.
Apache License 2.0
74 stars 14 forks source link

fix(dh): use untracked for language change #3526

Closed ManBearTM closed 1 month ago

ManBearTM commented 1 month ago

This PR fixes an NG0600 error when changing language (credit to @dzhavat). By wrapping the "business effects" in an untracked call, the error is gone and we also avoid future errors with signals from subscribers ending up as dependencies in this effect.

nx-cloud[bot] commented 1 month ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f75e32878d6362479611ae02d3fc29dcf4e84934. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets - [`nx run api-dh:build-client`](https://cloud.nx.app/runs/lXjxU8GPGd?utm_source=pull-request&utm_medium=comment) - [`nx run watt:build-storybook`](https://cloud.nx.app/runs/uegd1reame?utm_source=pull-request&utm_medium=comment) - [`nx build app-dh`](https://cloud.nx.app/runs/b1pQQqfLev?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.