EnergizedProtection / block

Let's make an annoyance free, better open internet, altogether!
https://energized.pro
MIT License
2.51k stars 198 forks source link

Domain format for mutiple lists contain invalid entries (including HTML) #547

Open lightswitch05 opened 4 years ago

lightswitch05 commented 4 years ago

Several lists in the domain format contain invalid entries (including some HTML). I'm sorry - your template doesn't really work great for this request and was making it difficult for me to give a proper error report. Ignore if you like.

Social

brands.medium.com
brand.twitter.com
        <br>Become a financial contributor and help us sustain our community.
        <br><br>
breffi-it.slack.com
bringinyourparents.linkedin.com
br.linkedin.com
broutonlab.slack.com
brownfarm.game.line.me
browseusers.myspace.com
browseusers.plus.google.com
br.pinterest.com
br.qzone.qq.com
        <br>Support this project with your organization. Your logo will show up here with a link to your website.
        <br>This donation is for our services, not for any pack, resource or any other mean. Your support will help us keep the project running and provide you quality service.
        <br>This project exists thanks to all the people who contribute.
br.vids.myspace.com
bs2dl-ssl.yy.com
discovery-aus.snapfish.com
discovery.snapfish.com
d.ish.instagram.com
        <div class="panel-body">
        <div class="panel-group" id="accordion">
      <div class="panel-heading">
            <div class="panel-heading">
    <div class="panel panel-default">
          <div class="panel panel-default">
    <div class="panel panel-default">
    <div class="wrapper">
      <div id="collapse10" class="panel-collapse collapse">
      <div id="collapse11" class="panel-collapse collapse">
      <div id="collapse12" class="panel-collapse collapse">
      <div id="collapse13" class="panel-collapse collapse">
          <div id="collapse1" class="panel-collapse collapse">
      <div id="collapse2" class="panel-collapse collapse">
      <div id="collapse3" class="panel-collapse collapse">
      <div id="collapse4" class="panel-collapse collapse">
      <div id="collapse5" class="panel-collapse collapse">
      <div id="collapse6" class="panel-collapse collapse">
      <div id="collapse7" class="panel-collapse collapse">
      <div id="collapse9" class="panel-collapse collapse">
dixonscarphone.m.facebook.com
dj.captcha.qq.com

Xtreme

Invalid entries:

regional

Invalid entries:

These invalid entries are not causing me any issues, but I thought you might want to know that your list has HTML in it.

DandelionSprout commented 4 years ago

Reopening until any other members of the Energized team can explain to me how to get changes to their build.sh scripts to take effect.

ghost commented 4 years ago

Looking at the entries for

button.blogs.yandex.
t.delfi.
tracking.olx.
track.zalando.

it appears that all just missing their TLDs. If multiple TLD are applicable for each such subdomain then adding a wildcard instead might solve it, e.g.

button.blogs.yandex.*
t.delfi.*
tracking.olx.*
track.zalando.*

? Unless it does not work that way or is too broad of TLD coverage in which case each subdomain would require probing as to which TLD(s) is/are applicable.

Unfortunately it is not clear how Core Xtreme List is being curated but it seems to be by the EP team with no apparent upstream sources.


time of writing checked subdomains validity against TLDs

ghost commented 4 years ago

it appears that all just missing their TLDs. If multiple TLD are applicable for each such subdomain then adding a wildcard instead might solve it [...] ? Unless it does not work that way

According to https://tools.ietf.org/html/rfc1034#section-4.3.3 TLD wildcard is not a viable option, thence those domains in question need to be either their TLD(s) declared or removed from the set since causing at trouble in some formats (RPZ at least).